After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601709 - bookmarks should use same custom icon as folder
bookmarks should use same custom icon as folder
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Bookmarks
2.28.x
Other Linux
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 619791
 
 
Reported: 2009-11-12 15:34 UTC by Pedro Villavicencio
Modified: 2011-01-12 18:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28

Attachments
proposed patch (2.91 KB, patch)
2010-07-24 17:27 UTC, Ahmad Sherif 		none Details | Review

Description Pedro Villavicencio 2009-11-12 15:34:59 UTC 
this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/nautilus/+bug/423890

"It is possible to chose a custom icon for a given folder in Nautilus by right-clicking and opening the folder's "properties" dialog. When the same folder is then added as a Nautilus bookmark, however, the generic folder icon is used.

It would be great if bookmarks shared the same icons as folder. This way a user could use a custom icon to make an important bookmark stand-out."

Thanks,
Comment 1 James Dupin 2010-02-13 17:40:12 UTC 
it surely is possible as the default bookmarks in Ubuntu (Music, Videos...) have the same icons as their original folders.

But creating new one indeed result in having the default folder icon.

Hope this is something trivial to correct or implement or document
Comment 2 Allan Day 2010-05-27 08:46:27 UTC 
Yes, that's a bug. Setting status to NEW. Thanks for the report.
Comment 3 Ahmad Sherif 2010-07-24 17:27:13 UTC 
Created attachment 166492 [details] [review]
proposed patch

My first Nautilus patch, I'd appreciate any comments or directions about it :).
Comment 4 Cosimo Cecchi 2011-01-12 18:45:05 UTC 
Hi Ahmad, thanks for the patch, and sorry it stayed not reviewed for such a long time.

NautilusBookmark's code needed some refactoring, so I pushed a cleaner bugfix to git master now. Closing as FIXED.