After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601673 - Unnecessary lines in MainWindow's ctor
Unnecessary lines in MainWindow's ctor
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
0.6.2
Other All
: Normal normal
: 0.7.0
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-12 11:27 UTC by Paul Wellner Bou
Modified: 2010-05-15 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch removing the two lines (471 bytes, patch)
2009-11-12 11:27 UTC, Paul Wellner Bou 		committed Details | Review

Description Paul Wellner Bou 2009-11-12 11:27:15 UTC 
543    query_widget.HandleChanged (query);

Added 2006 by Gabriel Burt. This is not necessary any more as this is called implicitely by UpdateFindByTagMenu (), which is called in MainWindow's ctor before. 

544    query_widget.Close ();

Added by Maxxer (July 2009), "Correctly set Find > Show/Hide find bar menu entry on startup". I don't think this is necessary as the Close () is called before several times. The mentioned UpdateFindByTagMenu () is calling the Close (), too, as the QueryWidget is visible by default on creation.
As far as I can tell it was not needed then, as it was called before, too.
Comment 1 Paul Wellner Bou 2009-11-12 11:27:51 UTC 
Created attachment 147560 [details] [review]
Patch removing the two lines
Comment 2 Ruben Vermeersch 2010-05-15 10:01:19 UTC 
Merged!

commit 8c9d7c7a34af9cf7008db06051b5e86cd0966df3
Author: Paul Werner Bou <paul@purecodes.org>
Date:   Fri Nov 20 13:08:47 2009 +0100

    Remove unnecessary lines (#601673)