After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601582 - pad: Keep track of the configured segment and add API to get it
pad: Keep track of the configured segment and add API to get it
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-11 17:37 UTC by Sebastian Dröge (slomo)
Modified: 2011-05-09 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pad: Keep track of the configured segment and add API to get it (7.03 KB, patch)
2009-11-11 17:37 UTC, Sebastian Dröge (slomo) 		none Details | Review
pad: Keep track of the configured segment and add API to get it (7.19 KB, patch)
2009-11-12 08:46 UTC, Sebastian Dröge (slomo) 		rejected Details | Review

Description Sebastian Dröge (slomo) 2009-11-11 17:37:53 UTC 
The attached patch keeps track of the configure segment by looking
at the NEWSEGMENT events and updates the last_stop for buffers
if their offset/timestamp is valid and the segment format is BYTES, TIME
or DEFAULT.

Also the segment is reset on FLUSH_STOP and after activating the pad.
Comment 1 Sebastian Dröge (slomo) 2009-11-11 17:37:55 UTC 
Created attachment 147491 [details] [review]
pad: Keep track of the configured segment and add API to get it
Comment 2 Olivier Crête 2009-11-11 19:02:13 UTC 
Review of attachment 147491 [details] [review]:

::: gst/gstpad.c
@@ +5420,3 @@
+ * This function gets the currently configured #GstSegment
+ * from this pad. The returned pointer is valid as long as
+ * the pad exists.

I guess you mean that the segment is copied, since it doesn't return a pointer.
Comment 3 Sebastian Dröge (slomo) 2009-11-12 07:23:50 UTC 
(In reply to comment #2)
> Review of attachment 147491 [details] [review]:
> 
> ::: gst/gstpad.c
> @@ +5420,3 @@
> + * This function gets the currently configured #GstSegment
> + * from this pad. The returned pointer is valid as long as
> + * the pad exists.
> 
> I guess you mean that the segment is copied, since it doesn't return a pointer.

Yes, right. The docs are from my first version that returned the segment ;) Thanks
Comment 4 Sebastian Dröge (slomo) 2009-11-12 08:46:07 UTC 
Created attachment 147546 [details] [review]
pad: Keep track of the configured segment and add API to get it

Fixes bug #601582.
Comment 5 Sebastian Dröge (slomo) 2011-05-09 10:08:48 UTC 
This is fixed different now in 0.11