After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601541 - Feature Request: Add 'Copy Image' Option In Evolution On Inline Email Images
Feature Request: Add 'Copy Image' Option In Evolution On Inline Email Images
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: Editing
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtkhtml-maintainers
gtkhtml-maintainers
evolution[composer] evolution[selecti...
Depends on:
Blocks:
 
 
Reported: 2009-11-11 13:55 UTC by David Richards
Modified: 2011-05-16 11:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed gtkhtml patch (1.49 KB, patch)
2010-03-17 19:54 UTC, Milan Crha
committed Details | Review
proposed evo patch (8.52 KB, patch)
2010-03-17 20:05 UTC, Milan Crha
committed Details | Review

Description David Richards 2009-11-11 13:55:57 UTC
When you are in Evolution and reading email, it would be a very useful feature to be able to "copy" the image to the clipboard.  This would allow you to them paste it into another email message or OpenOffice.  Right now you have to save the image to disk (/tmp or something) and then re-import it into another application.
Comment 1 Milan Crha 2009-11-11 13:59:03 UTC
are inline email images those attached, or the HTML message images? As for the attached it's out of evolution hand at the moment (in 2.29.2), because of change to GtkImageView.
Comment 2 David Richards 2009-11-11 14:05:58 UTC
I'm talking about messages inside the body of email that you receive.  So I guess I would call them HTML message images.
Comment 3 Matthew Barnes 2010-01-17 19:41:29 UTC
This would have to be done by right-clicking on the image and selecting a "Copy Image" item.  Copying a selection that includes the image won't work because that will copy it as HTML with an <img> tag.

GtkhtmlEditor would probably be the right place to implement this.
Comment 4 Milan Crha 2010-03-17 19:54:26 UTC
Created attachment 156395 [details] [review]
proposed gtkhtml patch

for gtkhtml;

New API function to get raw image data from GtkHTML.
Comment 5 Matthew Barnes 2010-03-17 20:00:58 UTC
Would it make more sense to return gdk_pixbuf_animation_get_static_image() instead of the animation object itself?  I don't think you can copy an animation to the clipboard.

We could always add gtk_html_get_animation_at() later if the need arises.
Comment 6 Milan Crha 2010-03-17 20:05:17 UTC
Created attachment 156396 [details] [review]
proposed evo patch

for evolution;

Evo UI part.
Comment 7 Milan Crha 2010-03-17 20:07:01 UTC
(In reply to comment #5)
> We could always add gtk_html_get_animation_at() later if the need arises.

That's what I was trying to avoid. To not restrict future use of it. Furthermore, the static pixbuf is held by the animation itself. (I didn't get it from the help page, somehow.)
Comment 8 Milan Crha 2011-05-16 11:22:56 UTC
No soname bump in gtkhtml, it was only API addition.
I made evo depend on that gtkhtml version.

Created commit 06524fd in gtkhtml master (4.1.2+)
Created commit d20e186 in evo master (3.1.2+)