After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601312 - Download filechooser dialog defaults to show "all supported files" instead of "all files"
Download filechooser dialog defaults to show "all supported files" instead of...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-09 21:34 UTC by Pacho Ramos
Modified: 2010-07-08 23:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Defaults to ALL Files on save_as dialog (764 bytes, patch)
2010-07-08 16:34 UTC, Jorge Kalmbach
committed Details | Review

Description Pacho Ramos 2009-11-09 21:34:08 UTC
It causes strange behavior when saving a file to a directory that, for example, contains pdf files, as, with epiphany-2.28, nothing is listed, while with previous epiphany versions, all files were listed.

From my point of view, there is no sense to default to "all supported files" for download dialog, since epiphany won't even be used to open downloaded files. Then, it should  default to "all files" instead

Thanks a lot
Comment 1 Reinout van Schouwen 2009-11-10 00:28:19 UTC
Possibly related: today I visit a page where I should upload a picture but the filechooser didn't show any supported filetypes (not even 'All'). Therefore I was unable to pick any file with the filechooser...
Comment 2 Wouter Bolsterlee (uws) 2010-01-02 17:15:14 UTC
Confirming. The save dialog should default to showing all files. The open dialog should default to showing only supported files.
Comment 3 Jorge Kalmbach 2010-07-08 16:34:12 UTC
Created attachment 165492 [details] [review]
Defaults to ALL Files on save_as dialog

Attached patch for Save_As dialog, the open dialog already shows ALL_SUPPORTED files by default.
Comment 4 Xan Lopez 2010-07-08 23:06:30 UTC
Comment on attachment 165492 [details] [review]
Defaults to ALL Files on save_as dialog

Makes sense.
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2010-07-08 23:16:18 UTC
Thanks Jorge, I pushed your patch with a small addition to also show all files
on *every* save-as dialog (internally we have two).