GNOME Bugzilla – Bug 600887
[common] Loading icon and title on Blu-ray video discs
Last modified: 2011-05-16 15:39:54 UTC
Only the common bits implemented, nothing in the volume monitor.
Created attachment 147041 [details] [review] [common] Loading icon and title on Blu-ray video discs Using the BDMV/META/DL/bdmt_eng.xml file on BDMV discs, we can load better names and icons for the disc.
Created attachment 147042 [details] directory from "Outlander" Blu-ray
See also: http://forum.doom9.org/showthread.php?p=1325366 from comment #11 onwards. Note that the patch I uploaded doesn't support reading from non-English files (which it probably should).
Sounds good to me, thanks for hacking on it. Maybe it would be nice to have a function that calls all of g_vfs_mount_info_query_autorun_info g_vfs_mount_info_query_xdg_volume_info g_vfs_mount_info_query_bdmv_volume_info and handles all the merging/logic of which information to use (based on priorities). Then things would Just Work(tm) when adding new sources of information too. Should probably take a flags parameter so people can turn off certain sources too. Thoughts?
Isn't that what's already done in update_mount()?
(In reply to comment #5) > Isn't that what's already done in update_mount()? It is. But presumably other volume monitors / mount daemons could (and should) use this code when determining the icon to use. And it seems a lot nicer to just have a single async function with all the business logic (e.g. prioritizing xdg_volume_info before Bluray) hidden inside it.
Created attachment 147309 [details] [review] [common] Loading icon and title on Blu-ray video discs Using the BDMV/META/DL/bdmt_eng.xml file on BDMV discs, we can load better names and icons for the disc. Adds expat requirement to the common library if it is found.
Created attachment 147310 [details] [review] [gdu] Use BDMV icon and name if available From the mount information, use the BDMV data if it is available.
I'd need to add a run-time dependency on iso-codes to be able to load the correct files for the user's language. Once all this is sorted, I'll look into moving all that code into common/ so it doesn't need to be copied in the various monitors.
Sounds good to me. FWIW, I think we should just make expat a hard dependency as a) it will already be available since it is needed for D-Bus (in the bus daemon); and b) it's small; and c) gio clients won't need it. Alex, is this OK with you?
Created attachment 147314 [details] and with a little icon
Attachment 147309 [details] pushed as cc467bf - [common] Loading icon and title on Blu-ray video discs Attachment 147310 [details] pushed as 3a862fe - [gdu] Use BDMV icon and name if available
Waiting on Alex' decision to make expat a hard-dependency, and add support for loading other locales. Then I'll move the code to get the favourite icon into a separate function as requested by David.
I'm fine with a hard dependency on expat. I assume GMarkup isn't good enough here?
(In reply to comment #14) > I'm fine with a hard dependency on expat. Great, thanks. > I assume GMarkup isn't good enough here? My original patch used GMarkup, and it failed to parse the doctypes.
I haven't moved anything, as the gdu backend is the only one we now care about, and I already replaced that code with something that uses libbluray to load the files, removing the need for an iso-codes dependency. Marking as FIXED.