After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600707 - autoconvert depends on function from core 0.10.26
autoconvert depends on function from core 0.10.26
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.17
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-04 17:20 UTC by Olivier Crête
Modified: 2009-11-04 23:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Olivier Crête 2009-11-04 17:20:55 UTC 
autoconvert uses gst_plugin_feature_list_copy() which was added in core after 0.10.25, so it can't be used in -bad until there is a new core release. I guess you can copy-paste the function in autoconvert for now.

While I'm looking at it, gst_plugin_feature_list_copy() seems overly complicated.
You can replace it with:

newlist = g_list_copy(oldlist);
g_list_foreach(newlist, (GFunc) g_object_ref, NULL);
Comment 1 Jan Schmidt 2009-11-04 23:18:42 UTC 
Coincidentally, I fixed this earlier today, but forgot to push it:

commit 7d53c392378458575d48d6b3fc873df6153c9760
Author: Jan Schmidt <thaytan@noraisin.net>
Date:   Wed Nov 4 15:21:50 2009 +0000

    resindvd,autoconvert: Avoid depending on 0.10.26 API
    
    Wait until after the next release to bump the core requirement.
    Until then, don't use gst_plugin_feature_list_copy and
    gst_pad_peer_get_caps_refed.
Comment 2 Jan Schmidt 2009-11-04 23:34:50 UTC 
Oops, plus this one:

commit f46c247757339ca06a360be31899af2f291b7752
Author: Jan Schmidt <thaytan@noraisin.net>
Date:   Wed Nov 4 23:32:07 2009 +0000

    autoconvert: Fix previous commit: ensure we take a ref on the features