GNOME Bugzilla – Bug 600685
Fails to subscribe to RSS podcast whose <title> is empty
Last modified: 2010-03-05 20:03:43 UTC
this report has been filed here: https://bugs.edge.launchpad.net/ubuntu/+source/banshee/+bug/468323 "Banshee fails to subscribe to an RSS podcast, whose <title> tag is empty. Test case http://kingworldnews.com/kingworldnews/Broadcast_Gold+/rss.xml Banshee will not subscribe to this feed I have reworked that podcast at the following address: http://www.315-web.com/kingworldnews.php The only difference between the original and the copy is that the latter has a proper <title> tag. In this case Banshee subscribes, sees the new episodes and downloads the latest one."
Created attachment 148273 [details] [review] Ignores empty title in Podcasts This patch fixes the issue. It avoids testing for the empty title in CheckRss() and when the title is empty, it substitutes the feed URL for the name in UpdateFeed()
Review of attachment 148273 [details] [review]: ::: src/Libraries/Migo/Migo.Syndication/RssParser.cs @@ +93,3 @@ try { feed.Title = StringUtil.RemoveNewlines (GetXmlNodeText (doc, "/rss/channel/title")); + if(String.IsNullOrEmpty(feed.Title)) { please follow the HACKING code style guide if( => if ( Empty( => Empty ( etc
Comment on attachment 148273 [details] [review] Ignores empty title in Podcasts I committed a different fix : still check for the presence of the title tag, and display "Unknown Podcast" if it's empty.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.