After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600605 - build failure with libXrandr 1.2 and randrproto 1.3 + major configure.ac cleanups
build failure with libXrandr 1.2 and randrproto 1.3 + major configure.ac clea...
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: general
SVN TRUNK
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-11-03 21:33 UTC by Rémi Cardona
Modified: 2010-03-21 11:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-Check-for-XRR-functions-using-library-version-instea.patch (3.08 KB, patch)
2009-11-03 21:34 UTC, Rémi Cardona
none Details | Review
0002-configure-clean-out-low-hanging-cruft.patch (2.87 KB, patch)
2009-11-03 21:35 UTC, Rémi Cardona
none Details | Review
0003-configure-use-pkg-config-instead-of-autoconf-macros-.patch (10.51 KB, patch)
2009-11-03 21:35 UTC, Rémi Cardona
none Details | Review
0004-configure-shrink-code.patch (6.51 KB, patch)
2009-11-03 21:35 UTC, Rémi Cardona
none Details | Review

Description Rémi Cardona 2009-11-03 21:33:15 UTC
See summary and attached patches, they should be self explanatory.

(I don't have a gnome account, so I'm going through bugzilla).

Thanks
Comment 1 Rémi Cardona 2009-11-03 21:34:35 UTC
Created attachment 146876 [details] [review]
0001-Check-for-XRR-functions-using-library-version-instea.patch

That one's the real important patch, this is a rebased version of what we're currently shipping in Gentoo on top of g-p-m 2.26.
Comment 2 Rémi Cardona 2009-11-03 21:35:01 UTC
Created attachment 146877 [details] [review]
0002-configure-clean-out-low-hanging-cruft.patch
Comment 3 Rémi Cardona 2009-11-03 21:35:19 UTC
Created attachment 146878 [details] [review]
0003-configure-use-pkg-config-instead-of-autoconf-macros-.patch
Comment 4 Rémi Cardona 2009-11-03 21:35:41 UTC
Created attachment 146879 [details] [review]
0004-configure-shrink-code.patch
Comment 5 Rémi Cardona 2009-11-03 21:36:33 UTC
 configure.ac                |  299 ++++++-------------------------------------
 src/Makefile.am             |    5 +-
 src/gpm-brightness-xrandr.c |   13 +-
 src/gpm-dpms.c              |   37 +-----
 4 files changed, 48 insertions(+), 306 deletions(-)

Thanks
Comment 6 Rémi Cardona 2009-12-08 07:31:39 UTC
Ping?
Comment 7 Richard Hughes 2009-12-08 09:39:47 UTC
Yup, all three look okay to me. Please can you send these to the mailing list for the other guys to review, and then I'll commit using git am there. Thanks.
Comment 8 Rémi Cardona 2010-03-10 09:03:12 UTC
Ping again? I've sent them to the mailing list, could you apply them?

Thanks
Comment 9 Richard Hughes 2010-03-21 11:08:58 UTC
I've committed most of these patches, a few hunks failed to apply, and a few needed massaging to apply. Could you please checkout git master and make sure everything looks okay? Thanks.