After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600584 - remove the install-data-local and uninstall-local targets
remove the install-data-local and uninstall-local targets
Status: RESOLVED FIXED
Product: anjal
Classification: Deprecated
Component: shell
git master
Other All
: Normal normal
: ---
Assigned To: anjal-maint
anjal-maint
Depends on:
Blocks:
 
 
Reported: 2009-11-03 18:27 UTC by Jonathon Jongsma
Modified: 2009-11-04 15:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove the install-data-local and uninstall-local targets (1.16 KB, patch)
2009-11-03 18:27 UTC, Jonathon Jongsma 		committed Details | Review

Description Jonathon Jongsma 2009-11-03 18:27:10 UTC 
`make install` is broken due to the install-data-local target.  The
$(desktop_file) variable is never defined, and so we get the following error
when trying to install:

n/bash ./mkinstalldirs /usr/local/share/applications;       \
  /usr/bin/install -c -m 644          \
      /usr/local/share/applications/ ; 
       /usr/bin/install: missing destination file operand after `/usr/local/share/applications/'

This custom target seems completely unnecessary and as far as I can tell,
removing it completely results in the .desktop file being installed as expected.
If I'm missing something, please let me know, but I think we can just drop these
targets.
Comment 1 Jonathon Jongsma 2009-11-03 18:27:12 UTC 
Created attachment 146861 [details] [review]
remove the install-data-local and uninstall-local targets

These are totally unnecessary targets and don't actually work (they cause `make
install` to fail).  automake generates rules to install the data automatically
when you define the desktopdir and desktop_DATA variables.
Comment 2 Travis Reitter 2009-11-03 18:43:53 UTC 
This patch works for me as well. (I had the same problem).
Comment 3 Srinivasa Ragavan 2009-11-04 10:17:11 UTC 
Comment on attachment 146861 [details] [review]
remove the install-data-local and uninstall-local targets

Please commit to anjal-0-1 and master.
Comment 4 Jonathon Jongsma 2009-11-04 15:17:56 UTC 
thanks.  committed to master, and cherry-picked to anjal-0-1