GNOME Bugzilla – Bug 600417
Always be aware of the account of a connection
Last modified: 2018-05-22 13:50:13 UTC
+++ This bug was initially created as a clone of Bug #599169 +++ > • empathy_get_account_for_connection: any reason why we don't have a > tp_account_manager_get_account_for_connection method? 13:50 < sjoerd> jonnylamb: because it's the wrong way round 13:50 < smcv> jonnylamb: probably YAGNI 13:50 < smcv> and that 13:50 < sjoerd> Empathy internally is slightly backwards because of historical reasons 13:50 < smcv> any time you have a Connection, you should already know the Account (and yes I realise that's not true in Empathy right now) So we should stop using empathy_account_for_connection.
Created attachment 167736 [details] [review] http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/account-600417 libempathy-gtk/empathy-chat.c | 5 +-- libempathy/empathy-call-factory.c | 2 +- libempathy/empathy-call-handler.c | 10 +++++-- libempathy/empathy-tp-call.c | 47 +++++++++++++++++++++++++----------- libempathy/empathy-tp-call.h | 5 +++- libempathy/empathy-tp-chat.c | 40 +++++++++++++++++++++++++++---- libempathy/empathy-tp-chat.h | 4 ++- src/empathy-chat-manager.c | 2 +- src/empathy-event-manager.c | 4 +- 9 files changed, 87 insertions(+), 32 deletions(-)
Here is a first step in this direction. There is only one call of empathy_get_account_for_connection() left in empathy-contact. Removing it will be a bit more work as we have to make the contact factory API account oriented.
Comment on attachment 167736 [details] [review] http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/account-600417 Branch has been merged. I keep the bug open as there is still one call left.
Let's see how https://bugs.freedesktop.org/show_bug.cgi?id=29417 goes as that's the last missing piece.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/139.