After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600417 - Always be aware of the account of a connection
Always be aware of the account of a connection
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Accounts
2.28.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-11-02 13:41 UTC by Jonny Lamb
Modified: 2018-05-22 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/account-600417 (13.26 KB, patch)
2010-08-12 14:50 UTC, Guillaume Desmottes
committed Details | Review

Description Jonny Lamb 2009-11-02 13:41:56 UTC
+++ This bug was initially created as a clone of Bug #599169 +++

> • empathy_get_account_for_connection: any reason why we don't have a
> tp_account_manager_get_account_for_connection method?

13:50 < sjoerd> jonnylamb: because it's the wrong way round
13:50 < smcv> jonnylamb: probably YAGNI                                         
13:50 < smcv> and that                                                          
13:50 < sjoerd> Empathy internally is slightly backwards because of historical
                reasons
13:50 < smcv> any time you have a Connection, you should already know the
              Account (and yes I realise that's not true in Empathy right now)

So we should stop using empathy_account_for_connection.
Comment 1 Guillaume Desmottes 2010-08-12 14:50:51 UTC
Created attachment 167736 [details] [review]
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/account-600417

 libempathy-gtk/empathy-chat.c     |    5 +--
 libempathy/empathy-call-factory.c |    2 +-
 libempathy/empathy-call-handler.c |   10 +++++--
 libempathy/empathy-tp-call.c      |   47 +++++++++++++++++++++++++-----------
 libempathy/empathy-tp-call.h      |    5 +++-
 libempathy/empathy-tp-chat.c      |   40 +++++++++++++++++++++++++++----
 libempathy/empathy-tp-chat.h      |    4 ++-
 src/empathy-chat-manager.c        |    2 +-
 src/empathy-event-manager.c       |    4 +-
 9 files changed, 87 insertions(+), 32 deletions(-)
Comment 2 Guillaume Desmottes 2010-08-12 14:52:07 UTC
Here is a first step in this direction. There is only one call of empathy_get_account_for_connection() left in empathy-contact. Removing it will be a bit more work as we have to make the contact factory API account oriented.
Comment 3 Guillaume Desmottes 2010-08-12 15:02:20 UTC
Comment on attachment 167736 [details] [review]
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/account-600417

Branch has been merged. I keep the bug open as there is still one call left.
Comment 4 Guillaume Desmottes 2010-08-13 09:19:36 UTC
Let's see how https://bugs.freedesktop.org/show_bug.cgi?id=29417 goes as that's the last missing piece.
Comment 5 GNOME Infrastructure Team 2018-05-22 13:50:13 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/139.