After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600409 - tremor/ivorbis: should pack result smarter
tremor/ivorbis: should pack result smarter
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-02 12:28 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2009-12-10 10:59 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Stefan Sauer (gstreamer, gtkdoc dev) 2009-11-02 12:28:43 UTC
the integer vorbisdecoder will create
audio/x-raw-int, 
        rate: [ 1, MAX ]
        channels: [ 1, 6 ]
        width: 32,
        depth: 16,
        signed: true

vorbis_synthesis_pcmout() produces 32bit int output. Either we offer 32bit int output or when running copy_samples() we pack it into 16 bit buffers. The current setup will cause the sink to most liekly repack again.
Comment 1 Mark Nauwelaerts 2009-12-10 10:59:15 UTC
Following commit adds a 16-bit width output option to the current one, with a slight preference for the former, so it should take care of this:

commit a93f6b8b386226580e83fa594eea3920f21bcb6c
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Tue Dec 8 18:57:49 2009 +0100

    ivorbis: also cater for traditional 16-bit width sample output