There is code to handle proxies in sj-metadata-musicbrainz3.c, I just think it's broken.

I'll try to fix it if it is not too difficult.

I found the problem and I'll post a workaround but it would probably be best for someone with a bit more programming experience to write a patch.


In sj-metadata-musicbrainz.c (Not musicbrainz3.c), in the sj_metadata_musicbrainz_init() function, the proxy settings for musicbrainz get set properly.

After the above function is called, the sj_metadata_musicbrainz_set_property() function gets called.  There is a SWITCH statement which in the function which sets the proxy settings (a second and third time) by calling the mb_SetProxy function to configure musicbrainz's proxy settings.  However, this resets the proxy settings because the data passed to the sj_metadata_musicbrainz_set_property() function is NULL or 0, and as far as I can tell, the priv->http_proxy and priv->http_proxy_port values never get set properly anywhere in the code.

sj_metadata_musicbrainz_init() gets called before sj_metadata_musicbrainz_set_property(), so when this second function is called it eliminates the proxy settings set by the first.

As a workaround, I compiled from source with the mb_SetProxy() calls in the sj_metadata_musicbrainz_set_property() function commented out.

If someone with proper coding knowledge can take a look and figure out a real solution, I would appreciate it!  This is a very annoying bug.  I should note that I compiled from the rhythmbox-0.12.8 source package.


static void
sj_metadata_musicbrainz_set_property (GObject *object, guint property_id,
                                      const GValue *value, GParamSpec *pspec)
{
...
  case PROP_PROXY_HOST:
...
    //mb_SetProxy (priv->mb, priv->http_proxy, priv->http_proxy_port);
    break;
  case PROP_PROXY_PORT:
    priv->http_proxy_port = g_value_get_int (value);
    //mb_SetProxy (priv->mb, priv->http_proxy, priv->http_proxy_port);
    break;
...
}

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/825.