GNOME Bugzilla – Bug 600372
Orca handles text configuration input incorrectly
Last modified: 2010-02-25 08:37:45 UTC
orca shouldn't allow gibberish as input into its configuration settings. I have no idea what the results of most of my choices actually were. Welcome to Orca setup. Select desired speech server. 1. Default Synthesizer 2. espeak 3. dummy Enter choice: f Enter choice: fsadf Enter choice: asdfasdf Enter choice: asdfa Enter choice: 1 Select desired voice: 1. default default voice (en) 2. afrikaans (af) 3. bosnian (bs) 4. catalan (ca) Original Ubuntu LP bug report https://bugs.edge.launchpad.net/ubuntu/+source/gnome-orca/+bug/469877
Created attachment 146902 [details] [review] Patch for check numerical choices Patch adds checks for numerical choices.
The second part of the bug relates to checkYes() function, couldn't find a way to patch that. help!
The checkYes method should be modified to return one of three states, say [True,False,None]. Then, all the code that calls it should check for the None value and reprompt.
Review of attachment 146902 [details] [review]: If you can get the checkYes stuff fixed as well, I'll take a look at trying to get this in. It will need to go into 2.29 and not 2.28 unless you can devise a way not to introduce any new strings for translation. Thanks!
Created attachment 147248 [details] [review] new patch to check user input Numeric returns are checked for intergers and checkYes() checks for yes or no and sets false for invalid response after printing a warning
Created attachment 147396 [details] [review] Patch that was committed Thanks Arky! There were a couple oddities with the patch, one of which was that it prompted you for key echo settings even if you said you didn't want key echo. I checked in this patch to master just now. Seems to work nicely, but please let me know if you have any concerns about it.
Thanks Willie, I will do that.
Setting this bug as 'FIXED'