After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600225 - Changing monitor configuration leads to (user-induced) endless cycle
Changing monitor configuration leads to (user-induced) endless cycle
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Federico Mena Quintero
Control-Center Maintainers
: 700496 707232 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-31 14:01 UTC by gpothier
Modified: 2013-09-11 13:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
display: disable the "Apply" button until a change has been made (7.64 KB, patch)
2013-09-09 17:03 UTC, Thomas Wood
committed Details | Review

Description gpothier 2009-10-31 14:01:20 UTC
The Apply button for the screen resolution config applet should be disabled when the user hasn't changed anything. Or, alternatively, it should not do anything. The issue is that having it enabled leads to the following endless cycle:

1. Open the Screen resolution config applet from System/Preferences
2. Change the settings of some monitor
3. Click apply
4. Screens are configured correctly
5. Click "maintain configuration" in the countdown dialog that pops up
6. The config applet is still displayed, with the Apply button enabled
7. Not sure what I should do, so click apply -> GOTO 5

This actually happened to my girlfriend. She was able to setup her external monitor all right but she said the countdown dialog would pop up over and over, and that was because she clicked apply over and over...

This is on Ubuntu Karmic, updated yesterday.
I originally filed a bug in Ubuntu but was told to file upstream: https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/465676
Comment 1 Jonh Wendell 2013-06-03 19:39:34 UTC
*** Bug 700496 has been marked as a duplicate of this bug. ***
Comment 2 Thomas Wood 2013-09-09 16:57:18 UTC
*** Bug 707232 has been marked as a duplicate of this bug. ***
Comment 3 Thomas Wood 2013-09-09 17:03:47 UTC
Created attachment 254508 [details] [review]
display: disable the "Apply" button until a change has been made
Comment 4 Rui Matos 2013-09-09 22:08:43 UTC
Review of attachment 254508 [details] [review]:

I think the request makes sense and the code looks good.

This is a (minor) UI break though so we need a freeze break exception.
Comment 5 Thomas Wood 2013-09-11 13:26:23 UTC
Attachment 254508 [details] pushed as 6192dd7 - display: disable the "Apply" button until a change has been made