After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600027 - [playbin2,playsink] Should notify about volume/mute changes
[playbin2,playsink] Should notify about volume/mute changes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-29 12:47 UTC by Sebastian Dröge (slomo)
Modified: 2009-10-29 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Dröge (slomo) 2009-10-29 12:47:09 UTC 
See summary, notify::volume should be emitted if the volume of the used volume/sink element is changed.
Comment 1 Tim-Philipp Müller 2009-10-29 13:04:09 UTC 
Wasn't there another bug about this as well? I remember loudly complaining about how we're falling back into ugly 0.8 habits. I think I'd prefer a message on the bus to notify the application of the volume change (can be both of course).
Comment 2 Sebastian Dröge (slomo) 2009-10-29 13:38:03 UTC 
That other bug was about tag changes :) And yes, you complained back then about going back to ugly 0.8 habits. But still, in any case, if a GObject property changes you should call g_object_notify(). That's what the commits below are doing.

Additionally a message would be nice though, right... but I don't need that (yet) ;)

commit d85dadc122d40608ee304516702b479fb79c8ed7
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Oct 29 14:30:31 2009 +0100

    playsink: Proxy notify::volume and notify::mute from the volume/mute elements (or sinks)
    
    Fixes bug #600027.

commit de1db5ccbdc10a835a2dfdd5984892f3b0c9bcf4
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Oct 29 14:19:09 2009 +0100

    playbin2: Proxy notify::volume and notify::mute from the playsink to playbin2