After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599997 - Add back support for "decrease size to fit screen size" for images
Add back support for "decrease size to fit screen size" for images
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: Backend
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-29 09:32 UTC by Sebastian Dröge (slomo)
Modified: 2018-03-30 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2009-10-29 09:32:54 UTC
See summary, Midori already does this with Webkit and epiphany did with gecko too.

If this should be fixed in webkit instead: https://bugs.webkit.org/show_bug.cgi?id=29918
Comment 1 Xan Lopez 2009-10-29 20:36:16 UTC
This is a setting, "auto-shrink-images" in WebKitGTK+, that we have set to FALSE and I guess Midori has set to TRUE, if I understand correctly what you are talking about. Does Midori show images shrinked by default allowing you to click to expand them?
Comment 2 Sebastian Dröge (slomo) 2009-10-30 06:16:07 UTC
Yes
Comment 3 Reinout van Schouwen 2009-12-19 17:59:55 UTC
Epiphany used to zoom 1:1 initially and allow to resize-to-screen on click. I'm in favor of re-implementing the old behavior.
Comment 4 Mario Sánchez Prada 2009-12-20 15:10:19 UTC
(In reply to comment #3)
> Epiphany used to zoom 1:1 initially and allow to resize-to-screen on click. I'm
> in favor of re-implementing the old behavior.

So you mean exactly the opposite behaviour to what Xan talked about in comment #2, don't you? That is, to show the original size by default and shrink if clicked only.
Comment 5 Mario Sánchez Prada 2009-12-20 21:18:05 UTC
I've filed a new bug in WebKit asking for the required changes to get this bug fixed. Also, suggested there two proposals to fix it and attached patches for both of them.

https://bugs.webkit.org/show_bug.cgi?id=32801

Depending on the proposal finally accepted (assuming of them would be accepted :-)) the patch for epiphany could be as simple as "do nothing" (no patch) or as adding a new hardcoded property,more or less this way (proposal 1):

diff --git a/embed/ephy-embed-prefs.c b/embed/ephy-embed-prefs.c
index a7cf60e..e032f0b 100644
--- a/embed/ephy-embed-prefs.c
+++ b/embed/ephy-embed-prefs.c
@@ -393,7 +393,8 @@ ephy_embed_prefs_init (void)
 
   /* Hardcoded settings */
   g_object_set (settings,
-                "auto-shrink-images", FALSE,
+                "auto-shrink-images", TRUE,
+                "auto-shrink-images-initially", FALSE,
                 "enable-default-context-menu", FALSE,
                 NULL);


Let's see how it evolves...
Comment 6 Mario Sánchez Prada 2010-06-14 16:36:35 UTC
(In reply to comment #5)
> I've filed a new bug in WebKit asking for the required changes to get this bug
> fixed. Also, suggested there two proposals to fix it and attached patches for
> both of them.
> 
> https://bugs.webkit.org/show_bug.cgi?id=32801

Looks like I forgot to add the review? flags in WK bugzilla back in December, so the patches got overlooked :(

Updated both of them against last trunk of WK and uploaded the new versions along with the review? flags. Hope we can get this fixed soon now...

Sorry for me being so absentminded :/
Comment 7 Mario Sánchez Prada 2010-08-10 08:49:24 UTC
Ping
Comment 8 Michael Catanzaro 2018-03-25 17:45:25 UTC
This is a mass NEEDINFO of all Epiphany bugs with no activity in the past three years. I'm going to be automatically closing old bugs to help us focus on current problems. If you feel this bug is still relevant with Epiphany 3.26 or newer, then please leave any comment here so that I know not to close this one.
Comment 9 Michael Catanzaro 2018-03-30 16:25:15 UTC
This is a mass-close of old bugs currently in the NEEDINFO state.

If you think this bug is still relevant, please leave a comment.