GNOME Bugzilla – Bug 599926
multihead fullscreen hides activities panel
Last modified: 2009-12-01 18:03:29 UTC
hi, i was testing gnome-shell git the other day. it's very nice und works very well, but there is one thing that's bugging me: if i run an application (eg tvtime) fullscreen on the second head, the activities panel on the primary head disappears.
*** Bug 597723 has been marked as a duplicate of this bug. ***
Created attachment 148687 [details] [review] only hide chrome if fullscreen window is on the same monitor testing the window coordinates/dimensions, as i did not find a definition of the fullscreen_screen per window. tested with transparent fullscreen gnome-terminal.
Comment on attachment 148687 [details] [review] only hide chrome if fullscreen window is on the same monitor the OVERRIDE_REDIRECT clause is incorrect too; it should also be checking against the primary monitor, not the screen. also, it would be nicer if you only called global.get_primary_monitor() once, outside the loop.
Created attachment 148798 [details] [review] merge if statements i merged the if statements, because the same conditions apply. primary monitor should not change between windows, so i pulled it out of the loop.
committed with whitespace fixes. Thanks for the patch
for eventual future patches .. what's the rule on whitespaces? tabs? space only?
spaces only. the whitespace problem that i fixed here was trailing whitespace on several lines. (at the end of the "let primary = ..." line, the blank line after it, and at the end of the "OVERRIDE_REDIRECT ||" line) if you have git configured to use color ("git config --global color.ui auto") then it will highlight trailing whitespace in red in a "git diff" so it's really obvious
ok, thx