GNOME Bugzilla – Bug 599865
bootstrap fails when top_srcdir is an absolute path
Last modified: 2020-03-03 18:34:47 UTC
Created attachment 146392 [details] [review] use abs_top_{build,src}dir Currently in bootstrap.make: _xml2po = PYTHONPATH="$(shell pwd)/$(top_builddir)/xml2po:$(shell pwd)/$(top_srcdir)/xml2po:$(PYTHONPATH)" "$(shell pwd)/$(top_builddir)/xml2po/xml2po" But if $top_srcdir is itself an absolute path, prepending $PWD to it is incorrect and breaks the build. I'm attaching a patch for 0.18.0 to use $abs_top_{build,src}dir to avoid any such problems.
Bug 591897 seems to say that one shouldn't use abs_top_builddir?
(In reply to comment #1) > Bug 591897 seems to say that one shouldn't use abs_top_builddir? The autoconf 2.64 manual[1] documents it, so I don't see why not. [1] http://www.gnu.org/software/autoconf/manual/autoconf.html#Preset-Output-Variables
abs_top_builddir is still documented in 2.68 with no indication that it is deprecated. I believe that the statement to the contrary in bug 591897 was erroneous.
*** Bug 667579 has been marked as a duplicate of this bug. ***
(In reply to comment #3) > abs_top_builddir is still documented in 2.68 with no indication that it is > deprecated. I believe that the statement to the contrary in bug 591897 was > erroneous. It seems that the issue in bug 591897 is not with autoconf 2.68, but with automake 1.9. Autoconf always sets abs_top_builddir and abs_top_srcdir, but automake 1.9 does not include those settings in the Makefile.in's it generates.
Created attachment 206852 [details] [review] 0001-Fix-building-out-of-tree.patch Updated patch to not depend on automake to set abs_top_{build,src}dir.
ping! Can someone please review my patch?
Is there a reason that you need to support boostrapping with automake < 1.11?
(In reply to comment #8) > Is there a reason that you need to support boostrapping with automake < 1.11? Why are you asking this? My patch https://bugzilla.gnome.org/attachment.cgi?id=206852 works with all automake versions. From my patch: # automake does not guarantee setting the abs_top_srcdir and # abs_top_buildir variables (and automake 1.9 in fact does not set them), # so we make sure we get them from autoconf. So, even if we do not want to support bootstrapping with automake < 1.11, we should handle bootstrapping with a future automake 1.12 that might not set the internal variables abs_top{build,src}dir. That is why my patch uses the autoconf variables instead of automake's. Now, if only we could get someone to actually apply https://bugzilla.gnome.org/attachment.cgi?id=206852 this bug could finally be closed!
Here is the patch we had to apply in Gentoo on 0.20.10 in order to support out-of-tree build. This is required for us to support multiple python installation at once. http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-text/gnome-doc-utils/files/gnome-doc-utils-0.20.10-fix-out-of-tree-build.patch
*** Bug 696993 has been marked as a duplicate of this bug. ***
gnome-doc-utils has been superseded by yelp-xsl, yelp-tools, and itstool. gnome-doc-utils will not see any further development, hence closing as WONTFIX. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/255