After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599795 - Implement type-ahead search in playlist widget
Implement type-ahead search in playlist widget
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-10-27 15:57 UTC by Tim-Philipp Müller
Modified: 2009-12-15 19:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
playlist: implement type-ahead search in the playlist widget (2.26 KB, patch)
2009-10-27 15:57 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2009-10-27 15:57:33 UTC
Created attachment 146352 [details] [review]
playlist: implement type-ahead search in the playlist widget

It would be nice if type-ahead search worked in the playlist widget, so that
you can jump to a particular song just by typing a few letters/words from its
filename/displayname or URI.
Comment 1 Bastien Nocera 2009-10-27 16:30:21 UTC
Probably a dupe of bug 313343.

Won't this break other "unmodified" keybindings (such as 'P' for play/pause, etc.)?
Comment 2 Tim-Philipp Müller 2009-10-27 16:46:31 UTC
> Probably a dupe of bug 313343.

Ah yes, looks like it, sorry. The patch here is complementary to the one in the other bug though.
 
> Won't this break other "unmodified" keybindings (such as 'P' for play/pause,
> etc.)?

I don't think so. It doesn't take over any key handling in addition to what's already done now.

It's only active if the playlist actually has focus, and if that is the case, special keys are not handled and passed to the treeview already in the current code (which will pop up a little search window at the bottom right of the playlist widget, but just not actually act on the stuff you type in).
Comment 3 Bastien Nocera 2009-10-27 16:50:21 UTC
Meeh, probably not any worse than before.

Feel free to commit both to master, and we'll have a couple of months to iron out the problems.