After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599794 - If I click Reply then close immediately, it asks me if I really want to
If I click Reply then close immediately, it asks me if I really want to
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.28.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[composer]
: 607679 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-27 15:49 UTC by Paul Smith
Modified: 2010-05-26 12:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (1.56 KB, patch)
2010-01-08 17:29 UTC, Milan Crha
committed Details | Review
evo patch ][ (for reopened drafts) (732 bytes, patch)
2010-05-26 12:45 UTC, Milan Crha
committed Details | Review

Description Paul Smith 2009-10-27 15:49:34 UTC
In older versions of Evo, if I clicked "reply" or "reply to all" then decided I didn't want to reply, before I changed anything, I could close the message and it goes away without question (since I didn't change anything).

With 2.28 if I close without changing the reply, it still asks me if I want to save the message/cancel/etc.

This is kind of annoying.
Comment 1 Akhil Laddha 2009-10-28 04:08:40 UTC
valid in 2.29.1 also
Comment 2 Milan Crha 2010-01-08 17:29:09 UTC
Created attachment 151043 [details] [review]
evo patch

for evolution;

just changing a flag to set it as not changed.
Comment 3 Milan Crha 2010-01-08 17:31:31 UTC
Created commit abc690c in evo master (2.29.5+)
Created commit bc16ee4 in evo gnome-2-28 (2.28.3+)
Comment 4 Paul Smith 2010-01-08 22:59:53 UTC
Oh yay!  Thanks for fixing this Milan.  I guess I'm just wishy-washy but I ran into this constantly and it really bugged me.

Cheers!
Comment 5 Matthew Barnes 2010-01-21 17:29:58 UTC
*** Bug 607679 has been marked as a duplicate of this bug. ***
Comment 6 Pablo Rodríguez 2010-05-24 12:07:41 UTC
Master seems still to be affected by this bug.

Could you reopen the bug? (It seems I don't have permissions or I don't know how to do it.)

Thanks,


Pablo
Comment 7 Milan Crha 2010-05-25 16:54:52 UTC
(In reply to comment #6)
> Master seems still to be affected by this bug.

Works for me on actual master like a charm. Staying on your bugzilla mail, hitting Ctrl+R, then Esc doesn't ask me for saving changes.
Comment 8 Milan Crha 2010-05-25 16:58:56 UTC
Ah, you meant with different steps, that's another story. As we spoke in
bug #617557, and as noted by you in bug #617557 comment #13:
> I also experience a weird bug when opening drafts. If I open and I close
> them without modifying them, the "Warning: Modified Message" dialog appears
> and this is wrong, since the message isn't modified.

Thus I'm reopening it.
Comment 9 Milan Crha 2010-05-26 12:45:26 UTC
Created attachment 162014 [details] [review]
evo patch ][ (for reopened drafts)

for evolution;

The other part, with reopened drafts and similar massages. The first chunk removes a function call which is unnecessary, as the function does nothing when both parameters are FALSE.
Comment 10 Milan Crha 2010-05-26 12:49:10 UTC
Created commit 3d9e2be in evo master (2.31.3+)
Created commit c9dc32f in evo gnome-2-30 (2.30.2+)