After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599779 - empathy doesn't auto finish IRC usernames when user hits tab
empathy doesn't auto finish IRC usernames when user hits tab
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Multi User Chat
2.28.x
Other All
: Normal enhancement
: ---
Assigned To: empathy-maint
: 575670 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-27 15:07 UTC by Benedict Stein
Modified: 2010-01-06 16:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Print autocompletion suggestions to chatview (1.13 KB, patch)
2010-01-02 13:16 UTC, Thomas Meire 		committed Details | Review

Description Benedict Stein 2009-10-27 15:07:17 UTC 
from: https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/458513

Binary package hint: empathy

Already said, try pidgin instead,

I've had problems to complete a 3 letter username on freenode, and I don't get a list of possibilitys if more than one user would with the asked letters.

ProblemType: Bug
Architecture: i386
Date: Thu Oct 22 22:10:45 2009
DistroRelease: Ubuntu 9.10
NonfreeKernelModules: nvidia
Package: empathy 2.28.1-1ubuntu1
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-14.48-generic
SourcePackage: empathy
Uname: Linux 2.6.31-14-generic i686
Comment 1 Francisco Rojas 2009-11-04 03:28:25 UTC 
apparently neither complete when the nickname contains non-alphanumeric character
Comment 2 Thomas Meire 2010-01-02 13:16:00 UTC 
Created attachment 150679 [details] [review]
Print autocompletion suggestions to chatview
Comment 3 Thomas Meire 2010-01-02 13:32:54 UTC 
Oh, and I didn't have any problems with short nicknames or non-alphanumeric charachters
Comment 4 Guillaume Desmottes 2010-01-06 11:48:46 UTC 
Review of attachment 150679 [details] [review]:

Thanks a lot for your patch. I fixed some style issues and pushed it to master.

::: libempathy-gtk/empathy-chat.c
@@ +1383,3 @@
 			gchar       *complete_char = NULL;
+			GString     *message = NULL;
+			GList       *l; 

This line introduced a trailing space.

@@ +1406,3 @@
+				 message = g_string_new ("");
+				 for (l = completed_list; l != NULL; l = l->next) {
+				 	g_string_append(message, empathy_contact_get_name((EmpathyContact*) l->data));

You should use function (arg);
No need to cast l->data
Comment 5 Guillaume Desmottes 2010-01-06 11:49:03 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 6 Guillaume Desmottes 2010-01-06 11:49:35 UTC 
*** Bug 575670 has been marked as a duplicate of this bug. ***
Comment 7 Benedict Stein 2010-01-06 16:23:23 UTC 
Thank you for fixing this bug.