After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599693 - Review comment preventing publishing the review
Review comment preventing publishing the review
Status: RESOLVED FIXED
Product: splinter
Classification: Infrastructure
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: splinter-maint
splinter-maint
Depends on:
Blocks:
 
 
Reported: 2009-10-26 20:21 UTC by Marina Zhurakhinskaya
Modified: 2009-10-27 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Line 48 on the right side of this diff was un-commentable (171.16 KB, image/png)
2009-10-26 20:23 UTC, Marina Zhurakhinskaya 		Details

Description Marina Zhurakhinskaya 2009-10-26 20:21:50 UTC 
It seems that there was a comment that I had in my review that was preventing publishing the review (nothing happened when I hit the Publish button). The review got published fine without that comment. There was the following error in the JS error log:
patchLines[0] is undefined from splinter.flat.js line 714

I'm attaching the screenshot of the diff I was commenting on.
Comment 1 Marina Zhurakhinskaya 2009-10-26 20:23:45 UTC 
Created attachment 146292 [details]
Line 48 on the right side of this diff was un-commentable