After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599549 - change the name of the panel icon
change the name of the panel icon
Status: RESOLVED WONTFIX
Product: vino
Classification: Applications
Component: Server
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-10-25 13:05 UTC by Nicolò Chieffo
Modified: 2020-11-12 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.10 KB, patch)
2009-10-25 13:05 UTC, Nicolò Chieffo 		needs-work Details | Review

Description Nicolò Chieffo 2009-10-25 13:05:15 UTC 
Created attachment 146205 [details] [review]
patch

if you enable vino through the controlcenter applet an icon is created in the
notification area. this icon should match the rest of notification area icons
(which in ubuntu are black and white).
Currently it looks slightly out of place.

My suggestion is to rename the icon used for the panel, so that it is different
from the one used in the menus.

I have a working patch that does this, using a GThemedIcon with default
fallbacks, so themes that don't ship the new icon will fallback to the one used
for menus.
Comment 1 Bastien Nocera 2013-01-28 18:23:02 UTC 
Review of attachment 146205 [details] [review]:

::: vino-2.28.1.orig/server/vino-status-icon.c
@@ +191,3 @@
+                            NULL);
+
+  icon = g_themed_icon_new_with_default_fallbacks (icon_name);

You could pass the GIcon directly to g_object_new() instead.

@@ +193,3 @@
+  icon = g_themed_icon_new_with_default_fallbacks (icon_name);
+  status_icon = (GTK_STATUS_ICON (vino_icon));
+  gtk_status_icon_set_from_gicon (status_icon, icon);

You're leaking a reference to the GIcon you just created, the function above takes a reference already.
Comment 2 André Klapper 2020-11-12 12:24:27 UTC 
Vino is not under active development anymore and unmaintained.

Please use gnome-remote-desktop instead.

Closing this report as WONTFIX to reflect reality.