After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599403 - Avoid using accel group internals in GtkSocket
Avoid using accel group internals in GtkSocket
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.90.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-10-23 13:38 UTC by Christian Dywan
Modified: 2010-09-08 23:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't use structure fields of GtkAccelMap in GtkSocket (2.90 KB, patch)
2009-10-23 13:38 UTC, Christian Dywan 		accepted-commit_now Details | Review

Description Christian Dywan 2009-10-23 13:38:24 UTC 
Created attachment 146100 [details] [review]
Don't use structure fields of GtkAccelMap in GtkSocket

In the 2.90 branch GtkAccelGroup's structure fields were removed, so GtkSocket
doesn't compile anymore. I wonder if we can fix this without access to these
members.

One point is removing all closures for a certain key and modifier. I think this
should work as is, but I'd like someone to check if it does what I think it
does.

The other point is, to remove all closures in a group. There is no API for
that. So I wondered if we should allow to pass NULL for the closure in
gtk_accel_group_disconnect to make that possible.
Comment 1 Matthias Clasen 2009-10-26 05:08:35 UTC 
Comment on attachment 146100 [details] [review]
Don't use structure fields of GtkAccelMap in GtkSocket

Looks ok to me.
Comment 2 Christian Dywan 2009-10-27 20:43:12 UTC 
Pushed to master.