After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599355 - [schroenc] doesn't use portable type
[schroenc] doesn't use portable type
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.15
Other Windows
: Normal normal
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-22 22:28 UTC by Andoni Morales
Modified: 2010-02-09 09:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
schroenc: Use guint64 instead of uint64_t (1.01 KB, patch)
2009-10-23 08:18 UTC, Edward Hervey 		committed Details | Review

Description Andoni Morales 2009-10-22 22:28:26 UTC 
In order to compile gstschroenc in windows the file gstschroenc.h should include <stdint.h>, where uint64_t is defined in win32 systems.
Comment 1 Edward Hervey 2009-10-23 08:18:46 UTC 
Created attachment 146085 [details] [review]
schroenc: Use guint64 instead of uint64_t
Comment 2 Tim-Philipp Müller 2009-10-23 08:49:41 UTC 
Odd, I'm sure the schroedinger headers include stdint.h somewhere already.

(And just for the record: GStreamer code should #include "_stdint.h" rather than <stdint.h>)

I think Edward's fix is best though, and should probably go in for the release.
Comment 3 Tim-Philipp Müller 2009-10-23 09:07:25 UTC 
Comment on attachment 146085 [details] [review]
schroenc: Use guint64 instead of uint64_t

Jan says this is OK to commit now.
Comment 4 Edward Hervey 2009-10-23 09:20:10 UTC 
commit e56b3ba6dc97333d005317d95e05d285e46d389b
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Fri Oct 23 10:18:12 2009 +0200

    schroenc: Use guint64 instead of uint64_t. Fixes #599355
Comment 5 Andoni Morales 2009-10-23 10:09:19 UTC 
(In reply to comment #2)
> Odd, I'm sure the schroedinger headers include stdint.h somewhere already.
> 
> (And just for the record: GStreamer code should #include "_stdint.h" rather
> than <stdint.h>)

Thanks for the tip :)