After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599218 - Deprecate gtk_button_pressed, _released, _enter, _leave
Deprecate gtk_button_pressed, _released, _enter, _leave
Product: gtk+
Classification: Platform
Component: Widget: Other
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Reported: 2009-10-21 16:55 UTC by Christian Dywan
Modified: 2009-10-27 21:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Deprecate the old button functions (960 bytes, patch)
2009-10-21 17:00 UTC, Christian Dywan
none Details | Review
Deprecate the old button functions, incl. tmpl update (2.38 KB, patch)
2009-10-21 17:03 UTC, Christian Dywan
accepted-commit_now Details | Review

Description Christian Dywan 2009-10-21 16:55:27 UTC
The signals "pressed", "released", "enter" and "leave" on GtkButton are deprecated because GtkWidget has all the functionality. However the according functions gtk_button_pressed, _released, _enter, _leave seem to have been forgotten.
Comment 1 Christian Dywan 2009-10-21 17:00:41 UTC
Created attachment 145964 [details] [review]
Deprecate the old button functions
Comment 2 Christian Dywan 2009-10-21 17:03:59 UTC
Created attachment 145965 [details] [review]
Deprecate the old button functions, incl. tmpl update

Updated patch, I accidentally left out the template file update.
Comment 3 Matthias Clasen 2009-10-26 05:11:52 UTC
Comment on attachment 145965 [details] [review]
Deprecate the old button functions, incl. tmpl update

Looks good to me, but you should remove the internal uses of these functions at the same time.
Comment 4 Javier Jardón (IRC: jjardon) 2009-10-27 00:16:24 UTC
Only a question: Make sense to deprecated _clicked and add a new signal to GtkWidget ?
Comment 5 Andrew Cowie 2009-10-27 00:42:52 UTC
No it doesn't.

GtkButtons are defined as things that the user can click, and it is entirely appropriate that they have a "clicked" signal when that happens.

Comment 6 Christian Dywan 2009-10-27 21:44:33 UTC
Pushed to master. I changed Gail, the old clist and combo to use g_signal_emit_by_name for now. We'll probably need to re-think what exactly Gail is doing there in the 2.90 branch.