GNOME Bugzilla – Bug 599193
Implement a Telepathy approver for text channel
Last modified: 2010-01-14 18:46:47 UTC
In order to implement the nice ideas presented in this mockup [1], gnome-shell should implement a Telepathy Approver [2] handling new incoming text channels. [1] http://www.gnome.org/~mccann/shell/mockups/20090630-demo/ [2] http://telepathy.freedesktop.org/spec/org.freedesktop.Telepathy.Client.Approver.html
Created attachment 146375 [details] [review] Add some very minimal telepathy support Original code from Will Thompson
Comment on attachment 146375 [details] [review] Add some very minimal telepathy support oops, meant to add a comment and mis-git-bz'ed anyway, not for review. known problems: (1) doesn't find pre-existing connections, only notices ones created after it starts up. (2) misses the first message on each connection. the commented-out avatar-loading code works, if we had someplace to put the avatar
Just some heads up about work we're doing to try and make this easier. I wrote a generator to generate hashes for all Telepathy interfaces from the spec, which you can get from this branch: http://git.collabora.co.uk/?p=user/danni/telepathy-glib.git;a=shortlog;h=refs/heads/js I'm also looking at GObject-Introspecting tp-glib's handwritten API (not the generated API -- I think we should use native calls for this), but there are problems caused by gjs not yet supporting callbacks. Also need to go through the API and add annotations for everything.
(In reply to comment #2) > known problems: (1) doesn't find pre-existing connections, only notices ones > created after it starts up. (2) misses the first message on each connection. (1) Long term Telepathy is going to grow some API to ask the Channel Dispatcher for existing channels you might like to observe. https://bugs.freedesktop.org/show_bug.cgi?id=24768 Short term you need to ask AccountManager for the ValidAccounts, get the Connection for each account, and then iterate that Connection for Channel objects on the bus. (2) You need to request pending messages from the Text Channel with ListPendingMessages.
Created attachment 146449 [details] [review] Add shell_texture_cache_load_from_data, for loading non-file-based images Based on a patch from Will Thompson
Created attachment 146450 [details] [review] Reorganize a bit, fix missing-first-message bug
Created attachment 146523 [details] [review] Add a notification popup for messages Use the notification popup when the messaging module receives new messages
Created attachment 146526 [details] [review] Add a notification popup for messages Use the notification popup when the messaging module receives new messages
message tray is committed, we're not using Telepathy currently. We might end up using it for some things later, but let's just close this bug to get it out of the way