After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599154 - RtpAudioPayload can send out buffers that are not exact multiple of the frame size
RtpAudioPayload can send out buffers that are not exact multiple of the frame...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-21 09:49 UTC by Olivier Crête
Modified: 2009-10-23 11:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtpaudiopayload: Only sent exact multiple of the frame size (1.17 KB, patch)
2009-10-21 09:49 UTC, Olivier Crête 		accepted-commit_now Details | Review

Description Olivier Crête 2009-10-21 09:49:02 UTC 
Created attachment 145937 [details] [review]
rtpaudiopayload: Only sent exact multiple of the frame size

If the amount if incoming data + content of the adapter get over the maximum
frame size (ie, the minimum of the mtu and the max-ptime), then the current
class just cuts it there without first aligning it with the frame size. The
attached patch first cuts it to the max frame size, then cuts it down to the
alignment.

Btw, this is a serious regression in 0.10.25, for anyone using framed audio
codecs with RTP..
Comment 1 Wim Taymans 2009-10-21 14:58:20 UTC 
Comment on attachment 145937 [details] [review]
rtpaudiopayload: Only sent exact multiple of the frame size

ouch yes...
Comment 2 Olivier Crête 2009-10-23 11:02:24 UTC 
Commited:

commit e27c24b2001bb1018b2cf3f11e74aaca301a66ff
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Wed Oct 21 12:38:59 2009 +0300

    rtpaudiopayload: Only sent exact multiple of the frame size
    
    Also align the maximum size with the frame size, not only the minimum