GNOME Bugzilla – Bug 599147
typefind : Avoid having to re-sort the typefind factory list
Last modified: 2009-10-24 08:51:20 UTC
The typefind helper features always re-sort the typefind factory list. The proposed patch modifies the registry subtlely to returned that factory list pre-sorted (whereas previously the order was undefined). Depends on #598896
Created attachment 145925 [details] [review] typefind: Keep typefind factories sorted in the registry This avoids having to do the sorting everytime we use typefind The behaviour of gst_type_find_factory_get_list has subtlely changed in the sense that the order was previously undefined, whereas now it returns them sorted by rank and then by name.
Review of attachment 145925 [details] [review]: Looks good... I don't think that behaviour change is a problem. Changing something from being undefined (and different depending on phase of moon and other things) to something defined is ok :)
Created attachment 146156 [details] [review] typefind: Keep typefind factories sorted in the registry This avoids having to do the sorting everytime we use typefind The behaviour of gst_type_find_factory_get_list has subtlely changed in the sense that the order was previously undefined, whereas now it returns them sorted by rank and then by name.
commit 5067664c09668384d57ccde51e6f2f62e1778cea Author: Edward Hervey <bilboed@bilboed.com> Date: Wed Oct 21 09:48:41 2009 +0200 typefind: Keep typefind factories sorted in the registry. Fixes #599147 This avoids having to do the sorting everytime we use typefind The behaviour of gst_type_find_factory_get_list has subtlely changed in the sense that the order was previously undefined, whereas now it returns them sorted by rank and then by name.