After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599050 - [mpegvideoparse] Does not check width/height range
[mpegvideoparse] Does not check width/height range
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.17
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-20 14:03 UTC by Thiago Sousa Santos
Modified: 2009-10-26 12:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch (1.15 KB, patch)
2009-10-20 14:03 UTC, Thiago Sousa Santos 		none Details | Review

Description Thiago Sousa Santos 2009-10-20 14:03:32 UTC 
Created attachment 145862 [details] [review]
The patch

Mpegvideoparse does not check width/height range, I'll attach a patch that
fixes it.

I opened this bug because I don't know if the current sequence header should be
updated to a "invalid" state when a sequence header is dropped.
Comment 1 Tim-Philipp Müller 2009-10-20 19:25:52 UTC 
Maybe, but the current code returns FALSE without invalidating the current sequence header as well, so your patch wouldn't make things any worse. I think it's essentially the same as assuming a wrong sync, I don't really see a problem with the way it works currently (or did I miss something?)
Comment 2 Thiago Sousa Santos 2009-10-26 12:14:03 UTC 
Fixed by:

Module: gst-plugins-bad
Branch: master
Commit: 106971243824bd756995f391e9ba2829ae31516a
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=106971243824bd756995f391e9ba2829ae31516a

Author: Thiago Santos <thiagoss@embedded.ufcg.edu.br>
Date:   Tue Oct 20 10:57:28 2009 -0300

mpegvideoparse: check width/height range

Checks if the width/height that are to be set on src pad caps
are within valid range of [16,4096]



(and again I forgot to add the bug number to the commit message :( )