GNOME Bugzilla – Bug 598936
DKS subtitle format
Last modified: 2009-10-22 08:02:56 UTC
GStreamer's subparse element does not support DKS subtitle format. I'll attach a patch soon.
Created attachment 145785 [details] [review] Implements support for DKS subtitle format in the subparse element Patch attached. Note for reviewers: DKS uses [br] for line breaks, just like subviewer 2.0 subtitles. The function subviewer_unescape_newlines replaces [br] with '\n' but instead of reusing this function I copied it with the name dks_unescape_newlines. Probably this was not a good idea, maybe renaming subviewer_unescape_newlines to something else that does not suggest that the function is subviewer specific is a better approach.
Could you make a testcase for this in tests/check/elements/subparse.c? Just copy the subviewer 2.0 test for example and use a small DKS subtitle stream as input.
Created attachment 146018 [details] [review] Implements support for DKS subtitle format in the subparse element (and tests) Same patch with the test. I also added a missing break that was causing a warning and renamed subviewer_unescape_newlines as unescape_newlines_br, which is now used from both the subparse and the dks parsers.
commit f63643bd547f14e0bcf9bf0f6cf6065e3ef1df20 Author: Iago Toral <itoral@igalia.com> Date: Thu Oct 22 10:02:11 2009 +0200 subparse: Add support for DKS subtitle format Fixes bug #598936.