After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 598908 - data project: multiple file rename do not work
data project: multiple file rename do not work
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
2.26.x
Other Linux
: Normal normal
: 2.26
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-10-19 10:16 UTC by Philipp Doorkeeper
Modified: 2009-10-19 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for this bug made on version 2.26.2 (11.71 KB, text/plain)
2009-10-19 10:16 UTC, Philipp Doorkeeper
Details

Description Philipp Doorkeeper 2009-10-19 10:16:11 UTC
Created attachment 145771 [details]
patch for this bug made on version 2.26.2

creating a new data project in brasero, adding some files, select multiple
files and press F2, a dialog appears "File Renaming".

i expect that this dialog change the names of all selected files at once. i
expect that this happens only in my project, but not at the file system. but
instead nothing happens. the filename keeps the same. 

1) when i choose "Renaming mode" "insert text" and enter some text in the
insert field and press rename afterwards, the dialog close, but the selected
filenames keep the same
2) when i chose one of the other three renaming modes and press rename, another
dialog box appears "Do you relly want to replace "filename"? (filename is
exactly the filename, not the renamed one) It doesn't matter if i press Keep
Project file or Replace Project file, the files are not renamed after i
answered all dialogs. the "do you really want to replace" dialog appears for
every file i selected. it also makes no difference to put any text in the text
fields (like in the field "Delete every occurence of").
There is another strange behavior. when i press Keep Project file in some cases
the dialog comes up again with the same question for the same file.

when i select a single file, i can rename it, that works fine.

i fixed that bug already and supply a patch. while i was at it, i added a new
feature, another rename strategy:
the strategy inserts a sequence of numbers at the beginning of the filenames.
there are a lot of mp3 cd players that play the files in alphabetic 8.3
filename order. with this feature, i can rip some audio cds, put them all on a
mp3 data cd, rename the files with a sequence at the beginning in every dir and
the files are exactly played in the same order as on the original audio cd and
the original filenames keep almost the same. if you google araound a bit, you
will find a lot of people with the same problem and this solution.

i reported this bug already on ubuntu:
https://bugs.launchpad.net/ubuntu/+source/brasero/+bug/447081.the automatic
created bug environment info can be found there.

Architecture: i386
DistroRelease: Ubuntu 9.04
ExecutablePath: /usr/bin/brasero
Package: brasero 2.26.1-0ubuntu1
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: brasero
Uname: Linux 2.6.28-15-generic i686

if there is anything i can do to support you, please let me know
Comment 1 Philipp Doorkeeper 2009-10-19 10:22:37 UTC
i tested the patch of course, it worx for me.
Comment 2 Philippe Rouquier 2009-10-19 14:29:06 UTC
Thanks for the report. The bug itself was fixed in master, gnome-2-28 branch though I did not commit your patch as is. Your diagnostic was correct but I fixed it in a different way that I like better since you patch broke when function brasero_rename_set_show_keep_default () was called with FALSE as value.
As for your addition, I committed part of your patch and again I modified it.

Thanks again for your patch but next time, please try to use diff command or even better git diff if you are using a tree from git.gnome.org. That way I don't have to diff your file against the original tree to get the changes.
Comment 3 Philipp Doorkeeper 2009-10-19 15:03:35 UTC
thx a lot for integrating my addition and the fix it so fast. 

i checked it out and test it it on my system. perfect, works for me and i love the new renaming feature.