GNOME Bugzilla – Bug 598905
Should request channels via the channel dispatcher
Last modified: 2011-08-29 10:12:28 UTC
To live in the bright new telepathy future empathy should requests its channels from the Channel Dispachter instead of directly from the connection managers. This is unfortunately blocked by: https://bugs.freedesktop.org/show_bug.cgi?id=23651 Fixes are ready in http://git.collabora.co.uk/?p=user/sjoerd/empathy.git;a=shortlog;h=refs/heads/requests-2-28 for the gnome-2-28 branch and http://git.collabora.co.uk/?p=user/sjoerd/empathy.git;a=shortlog;h=refs/heads/requests for master. This branch is already shipped by moblin as they need it to make the observer in their people panel work correctly, the mission-control issue doesn't hit them as they don't use any other telepathy handlers (like nautilus-sendto)
We want this in 2.30.
The fix for bug #598332 has probably raise conflicts with this branch. It should be rebased.
Few comments after a quick review: • You should probably rebase your branch on top of master and check it still build (we enabled more compiler warnings) • dispatcher_channel_request_failed_cb: const gchar *error, const gchar *message, should be on 2 lines • empathy_dispatcher_call_create_or_ensure_channel: shouldn't you check if account is != NULL ?
Currently 17 Empathy tickets are set as GNOME 2.30 blockers, hence mass-removing. Guillaume: Please use normal Target Milestones instead. If you really think that this specific issue here is a 2.30 blocker then please restore the GNOME target and set corresponding importance values.
Re-assigning to Sjoerd as he's the responsable of this branch.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.