After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 598778 - [PATCH] Fix 'clutter-1.0.vapi'
[PATCH] Fix 'clutter-1.0.vapi'
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
0.7.x
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-17 15:53 UTC by Frederik Zipp
Modified: 2009-11-12 22:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix 'clutter-1.0.vapi' (51.45 KB, patch)
2009-10-17 15:55 UTC, Frederik Zipp 		none Details | Review
Fix 'clutter-1.0.vapi', 2nd version (51.44 KB, patch)
2009-10-18 09:46 UTC, Frederik Zipp 		rejected Details | Review

Description Frederik Zipp 2009-10-17 15:53:31 UTC 
Lots of fixes (out parameters, array lengths, delegates, [NoAccessorMethod]s, remove private fields, 'dup_function' metadata, ...).
Comment 1 Frederik Zipp 2009-10-17 15:55:10 UTC 
Created attachment 145675 [details] [review]
Fix 'clutter-1.0.vapi'
Comment 2 Frederik Zipp 2009-10-18 09:46:34 UTC 
Created attachment 145725 [details] [review]
Fix 'clutter-1.0.vapi', 2nd version

bind string arrays correctly
Comment 3 Jaap A. Haitsma 2009-10-18 15:35:44 UTC 
Review of attachment 145725 [details] [review]:

You should use metadata files etc. like described in
http://live.gnome.org/Vala/Bindings
Comment 4 Frederik Zipp 2009-10-20 18:08:51 UTC 
(In reply to comment #3)
> Review of attachment 145725 [details] [review]:
> 
> You should use metadata files etc. like described in
> http://live.gnome.org/Vala/Bindings

Yes, however, I used what was there. The 'clutter-1.0.vapi' currently shipped with Vala has no vapigen package directory. I'm not sure if that's intentional.
Comment 5 Jaap A. Haitsma 2009-10-20 20:43:41 UTC 
(In reply to comment #4)
> 
> Yes, however, I used what was there. The 'clutter-1.0.vapi' currently shipped
> with Vala has no vapigen package directory. I'm not sure if that's intentional.

That's a bug. So please provide a patch with a package directory
Comment 6 Frederik Zipp 2009-11-12 22:15:18 UTC 
Fixed with commit 2fdf8664c3f7a6a19253ae897fb3d085b6b20b38

"clutter-1.0: Replaced the clutter-1.0 bindings with generated ones"