GNOME Bugzilla – Bug 598771
Fix build without pango
Last modified: 2009-10-18 12:50:06 UTC
Not everybody has it :)
Created attachment 145669 [details] [review] build: don't fail with old pango versions Somebody forgot that 'pangocairo >= 1.15.4' can fail. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Created attachment 145670 [details] [review] build: avoid pango version check if it's not there Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> build: don't fail with old pango versions > Somebody forgot that 'pangocairo >= 1.15.4' can fail. Hrm, not quite sure I understand what the exact problem is here. Maybe the real problem is rather that gsttextoverlay.c uses #if HAVE_FOO_BAR where it should be using #ifdef HAVE_FOO_BAR ? I think I'll just bump the pango requirements here btw and get rid of those ifdefs anyway. > build: avoid pango version check if it's not there That makes sense, but wouldn't be needed any longer if the reqs get bumped.
Created attachment 145691 [details] [review] pango: bump pango requirement and remove ifdef
(In reply to comment #3) > > build: don't fail with old pango versions > > Somebody forgot that 'pangocairo >= 1.15.4' can fail. > > Hrm, not quite sure I understand what the exact problem is here. Maybe the real > problem is rather that gsttextoverlay.c uses #if HAVE_FOO_BAR where it should > be using #ifdef HAVE_FOO_BAR ? > > I think I'll just bump the pango requirements here btw and get rid of those > ifdefs anyway. Read 'man pkg-config': If a module is missing or has the wrong version, by default configure will abort with a message. If we don't want to abort, we need to provide an "action if not found". > > build: avoid pango version check if it's not there > > That makes sense, but wouldn't be needed any longer if the reqs get bumped. That's unnecessary, but meh.
Yes, let's bump the pango version. 1.15.4 is already 2 3/4 years old, that's older than our required glib version (which is ~1 year old).
> Read 'man pkg-config': > If a module is missing or has the wrong version, by default configure will > abort with a message. > > If we don't want to abort, we need to provide an "action if not found". Ah, ok. Now I understand. I was confused because I was looking at configure.ac as in current git where this is fixed already [1]. [1] http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=4a6d97cda03596c7dcbaa926e5029d68c9335735 > > That makes sense, but wouldn't be needed any longer if the reqs get bumped. > > That's unnecessary, but meh. It really doesn't make a difference to anyone. 1.15.4 is an unstable developement release, and an ancient one at that. Anyone with a sane setup will have either 1.14.x or 1.16.x or something else installed, so bumping it to 1.16 will not make anyone worse off.