After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 598768 - Use recommended autoconf input name: `'
Use recommended autoconf input name: `'
Product: gtk+
Classification: Platform
Component: .General
Other All
: Normal trivial
: ---
Assigned To: gtk-bugs
Depends on:
Reported: 2009-10-17 14:33 UTC by Martin Nordholts
Modified: 2010-05-07 08:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments (139.09 KB, patch)
2009-10-17 14:33 UTC, Martin Nordholts
committed Details | Review
Rename to (138.03 KB, patch)
2010-03-25 19:56 UTC, Javier Jardón (IRC: jjardon)
none Details | Review

Description Martin Nordholts 2009-10-17 14:33:51 UTC
Created attachment 145665 [details] [review]

In the autoconf manual [1] the name `' is promoted and
`' is considered legacy. The attached patch renames to and changes references to the file accordingly. It also does some
whitespace cleanup so that the patch can be applied without git complaining.

Comment 1 Martin Nordholts 2009-10-17 14:35:14 UTC
Forgot to say that I'm ready to push this as soon as I get an OK.
Comment 2 Christian Persch 2009-10-17 20:48:28 UTC
One thing this will break is automatic reconfigure when running make after switching between master and a branch that still uses (or on master while bisecting over this change).
Comment 3 Christian Dywan 2009-10-18 18:14:44 UTC
Is there any practical advantage?
Comment 4 Martin Nordholts 2009-11-07 11:37:13 UTC
Oops I must have missed the last bugzilla mail

The practical advantage is that GTK+ will have the Autoconf input name that developers expect. As time passes, more and more will expect the name to be
Comment 5 Matthias Clasen 2009-11-28 02:11:02 UTC
As I said on the list the other day, I don't see a big advantage, but I don't mind it. So just go ahead.
Comment 6 Javier Jardón (IRC: jjardon) 2010-03-25 19:56:13 UTC
Created attachment 157098 [details] [review]
Rename to

Reworked patch against latest master.

Also, use AM_MAINTAINER_MODE([enable]) instead AM_MAINTAINER_MODE because disables dependency-checking for autotools-generated stuff.

More info about this here [1] and [2]

Comment 7 Javier Jardón (IRC: jjardon) 2010-05-07 08:09:44 UTC
Comment on attachment 145665 [details] [review]

commit ccc53b9a45f35af358d1387a6db14838d6977fd4
Comment 8 Javier Jardón (IRC: jjardon) 2010-05-07 08:09:58 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.