GNOME Bugzilla – Bug 598552
faac: Clean up defaults
Last modified: 2009-10-27 12:10:42 UTC
Created attachment 145514 [details] [review] Make the default block type value consistent, allowing both short and long blocks, which is the value in gst_faac_init Here are a series of three patches to clean up the defaults a little. 1 - Make the default block type value consistent, allowing both short and long blocks, which is the value in gst_faac_init 2 - Change the default AAC Profile from Main to Low Complexity as this is more widely supported and used. 3 - Make definitions for default values to allow their future alteration with greater ease and reduced chance of consistency issues.
Created attachment 145515 [details] [review] Change the default AAC Profile from Main to Low Complexity as this is more widely supported and used.
Created attachment 145516 [details] [review] Make definitions for default values to allow their future alteration with greater ease and reduced chance of consistency issues.
Comment on attachment 145514 [details] [review] Make the default block type value consistent, allowing both short and long blocks, which is the value in gst_faac_init Thanks, these look all good to me. We'll committ them once -bad thaws again. >From: Robert Swain <rob@fluffy.(none)> Please set a proper e-mail address. See http://gstreamer.freedesktop.org/wiki/GitDeveloperGuidelines towards the bottom for the commands to run. >Subject: [PATCH 1/3] faac: Change the param_spec default value for allowed block types to match > the gst_faac_init value of 'normal' as this is better Nitpick: your summary lines are all a tad long IMO (no need to change it now, just for the future).