GNOME Bugzilla – Bug 598523
Protect hidden layers from editing
Last modified: 2013-05-13 21:33:10 UTC
You can now edit hidden layers although you wont see what you've done, like drawing a brush stroke over the whole layer. This may be in error and you are not aware of whats been done. When you turn on visibility layer and find out, it may be too late, you've already done a lot of work to other layers so it would mean more work to undo. I can't think of any situation where one would like to edit an invisible layer so I would like non visible layers to be protected from editing.
I do. I sometimes edit layer A according to visual guides in layer B, such as A would hinder said guides if visible. I don't want to have to move layers around or tinker their blend mode just to do that. That said, I often find myself editing a hidden layer by mistake. What we need here is... sorry, dunno.
What we need here is a user-selectable option, since acting upon a hidden layer is often a mistake, but there may be situations where it is desired. If we compare a different app, Inkscape, it will not let you perform certain operations if the target is a hidden layer; if you try, the statusbar will merely tell you "Current layer is hidden; unable to draw or act upon it".
*** Bug 695398 has been marked as a duplicate of this bug. ***
This is trivial to implement, the very same way we protect locked layers and group layers from being edited. A nice core patch for a new contributor.
Created attachment 242288 [details] [review] Patch to fix bug 598523 I got a working patch here. It is my first patch, so please don't be too mad (or something)
That's a good start, can you please fix the formatting and spacing, which means mostly no tabs and spaces before each '('.
Created attachment 242329 [details] [review] Patch to fix bug 598523 Updated.
Thanks, fixed in master. Lest treat all missing things as separate bugs, I think the ones we have now are the most obvious with little potential for discussion. commit ac5428787e238282fdbf1359ebfd4445cb0fcec8 Author: darkraid1 <darkraid1@gmail.com> Date: Wed Apr 24 16:27:12 2013 +0200 Bug 598523 - Protect hidden layers from editing Don't allow tool operations on invisible items, just like we do for group layers or locked items. Cleaned up and enhanced the patch a bit --Mitch app/tools/gimpblendtool.c | 10 +++++++++- app/tools/gimpbucketfilltool.c | 10 +++++++++- app/tools/gimpimagemaptool.c | 7 +++++++ app/tools/gimppainttool.c | 10 +++++++++- app/tools/gimptransformtool.c | 12 ++++++++++-- 5 files changed, 44 insertions(+), 5 deletions(-)