Created attachment 184086 [details] [review]
Use Gtk::Spinner instead of custom spinner widget

    * src/uicommon/nmv-spinner-tool-item.[cc,h]: Rewrote to use
    Gtk::Spinner instead of EphySpinner.
    * src/persp/dbgperspective/nmv-dbg-perspective.cc: Adapt to
    nmv-spinner-tool-item changes.
    * src/uicommon/ephy-spinner-tool-item.[c,h]:
    * src/uicommon/ephy-spinner.[c,h]:
    * src/uicommon/nmv-spinner.[cc,h]: Removed EphySpinner and its C++
    wrappers.
    * src/uicommon/Makefile.am: Removed references to deleted files.
    * configure.ac: Bumped gtkmm minimum version to 2.20.

I have started working on Nemiver's GTK+ 3 port and getting rid of EphySpinner should make porting easier.

[...]

diff --git a/src/uicommon/nmv-spinner-tool-item.cc b/src/uicommon/nmv-spinner-tool-item.cc
index 1b6f24e..893051f 100644
--- a/src/uicommon/nmv-spinner-tool-item.cc
+++ b/src/uicommon/nmv-spinner-tool-item.cc
@@ -22,120 +22,50 @@

[...]

-SpinnerToolItem::~SpinnerToolItem ()
+SpinnerToolItem::SpinnerToolItem () :
+    Gtk::ToolItem ()

I think the 'Gtk::ToolItem ()' mem-initializer is not necessary here,
Just doing away with it should work because the sub-object of the
Gtk::ToolItem base class would then be default-initialized.

Other than that, the patch look good to me.

Once you've addressed my comment above, you can commit the patch to
the git master branch and close the bug as fixed.

Thank you very much for the patch!

> I have started working on Nemiver's GTK+ 3 port

Woohoo.  Thank you for that!

Maybe you could add a little comment to
https://bugzilla.gnome.org/show_bug.cgi?id=633546 to avoid duplicated
efforts?  Not that people are going to rush for this but hey, who
knows :-)

Created attachment 184142 [details] [review]
Use Gtk::Spinner instead of custom spinner widget

(In reply to comment #2)
> +SpinnerToolItem::SpinnerToolItem () :
> +    Gtk::ToolItem ()
> 
> I think the 'Gtk::ToolItem ()' mem-initializer is not necessary here,
> Just doing away with it should work because the sub-object of the
> Gtk::ToolItem base class would then be default-initialized.

Agreed. Thanks for the review!

I have attached an updated patch. I don't however have a GNOME git account, would you mind committing it for me?

OK, I have committed the patch into master the master branch.  The
commit hash is b4bdfe9.

I have just edited the commit log to comply with the rules explained
in git-commit-messages.README.

Thank you very much!