After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 598442 - Use GtkSpinner
Use GtkSpinner
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
2.29.x
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 613178
 
 
Reported: 2009-10-14 15:40 UTC by Bastien Nocera
Modified: 2010-10-24 10:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port to GtkSpinner (7.20 KB, patch)
2009-11-02 10:36 UTC, Xan Lopez 		none Details | Review

Description Bastien Nocera 2009-10-14 15:40:28 UTC 
Instead of a copied around spinner widget.

See https://bugzilla.gnome.org/show_bug.cgi?id=319607
Comment 1 Xan Lopez 2009-11-02 10:36:16 UTC 
Created attachment 146732 [details] [review]
Port to GtkSpinner
Comment 2 Xan Lopez 2009-11-02 10:38:19 UTC 
Previous patch is just a quick try I did of this in a few minutes this morning. Some problems:

- Spinner animation is not reset to "rest" state when stopped, so it looks awkward.
- Need to set the size request manually when putting the spinner in a toolitem.
- It looks pretty bad when packed in the tabs.

I'd say the first is a bug to fix in GTK+, not sure about the second one, and the third one is probably a matter of taste.
Comment 3 Bastien Nocera 2009-11-02 11:57:03 UTC 
There's no rest animation in GtkSpinner (actually, in the GtkStyle default vfunc). That's expected.
Comment 4 Xan Lopez 2009-11-02 12:05:44 UTC 
(In reply to comment #3)
> There's no rest animation in GtkSpinner (actually, in the GtkStyle default
> vfunc). That's expected.

Sure, not saying it's not expected, just that I think it should work like that.
Comment 5 Xan Lopez 2010-10-24 10:26:16 UTC 
Pushed this to master, although now spinners are only used in tabs.

Commit c255df464cf44e9687f80c5845e5f31a500f7084