GNOME Bugzilla – Bug 598248
Properly detect pre-releases
Last modified: 2010-02-09 10:00:07 UTC
currently -Werror is used for pre-releases. The problem is that it's added when GST_CVS/GST_GIT is True... which is when the nano number is present. GST_CVS/GST_GIT should only be True for nano == 1
Created attachment 145398 [details] [review] m4/as-version: Make AS_NANO set RELEASE if nano != 1 If code using AS_NANO wants finer grained control, they should use the PACKAGE_VERSION_NANO.
Created attachment 145399 [details] [review] m4/gst-args: Properly set the package name for git/pre-release/release
The two patches above properly detect pre-releases. They will set GST_CVS/GST_GIT to FALSE if nano != 1 They will set GST_PACKAGE_NAME to the proper name ("git","prerelease","source release")
Looks good to me
commit 85d153002980ca1341b34681c2172bd00080b4ed Author: Edward Hervey <bilboed@bilboed.com> Date: Wed Oct 14 08:40:11 2009 +0200 m4/gst-args: Properly set the package name for git/pre-release/release https://bugzilla.gnome.org/show_bug.cgi?id=598248 commit 6ca472b7404c89a5533d435cc5a09ec3f52d55f2 Author: Edward Hervey <bilboed@bilboed.com> Date: Wed Oct 14 08:38:47 2009 +0200 m4/as-version: Make AS_NANO set RELEASE if nano != 1 If code using AS_NANO wants finer grained control, they should use the PACKAGE_VERSION_NANO. https://bugzilla.gnome.org/show_bug.cgi?id=598248