After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 598212 - Wrong file removed in tree viewer with Move to Trash
Wrong file removed in tree viewer with Move to Trash
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-12 21:56 UTC by Richard Eames
Modified: 2019-03-23 20:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for Bug 598212 (1.33 KB, patch)
2009-10-22 04:57 UTC, Travis Fickett
none Details | Review

Description Richard Eames 2009-10-12 21:56:55 UTC
When using the "Move to Trash" option in the right click menu on the File Browser pane in Gedit, the currently hightlighted file - instead of the file under the right click - is moved to the trash.

Steps to reproduce:
1: Create two "New Files" in the File Browser pain. Call them "foo" and "bar". After creating the second one, it should be highlighted.
2: Right click on the unhighlighted file, choose "Move to Trash"

Expected behaviour: The file which is right clicked on should be sent to trash.
Actual Behaviour: The highlighted file is sent to trash.

This actually happens to all the menu items, such as rename.

ProblemType: Bug
Architecture: amd64
Date: Sun Oct 11 13:52:57 2009
DistroRelease: Ubuntu 9.10
Package: gedit 2.28.0-0ubuntu1
ProcEnviron:
 PATH=(custom, user)
 LANG=en_CA.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-13.44-generic
SourcePackage: gedit
Uname: Linux 2.6.31-13-generic x86_64

Reported downstream: https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/449001
Comment 1 Travis Fickett 2009-10-22 04:57:33 UTC
Created attachment 146016 [details] [review]
Patch for Bug 598212

Hi, I created this patch to change the functionality of the filebrowser plugin to the expected behaviour. What it does is select the item under the cursor if you right click and one or less items is selected in the tree view already.  If more than one item is selected it does not change anything. 

It's my first patch so I expect I've messed something up.  Please take a look at it.
Comment 2 jessevdk@gmail.com 2009-11-15 20:50:06 UTC
Thanks for the patch! I've committed this (with some minor code style modifications) to the current development branch.