After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597925 - make check fails to find test*.js files
make check fails to find test*.js files
Status: RESOLVED DUPLICATE of bug 613234
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2009-10-09 17:15 UTC by Tommi Komulainen
Modified: 2011-01-10 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test: handle absolute GJS_TOP_SRCDIR correctly (1.56 KB, patch)
2009-10-09 17:15 UTC, Tommi Komulainen 		none Details | Review

Description Tommi Komulainen 2009-10-09 17:15:10 UTC 
Failing g_assert in gjs-unit:

    /* iterate through all 'test*.js' files in ${top_srcdir}/test/js */
    js_test_dir = g_build_filename(top_srcdir, "test", "js", NULL);
    dir = g_dir_open(js_test_dir, 0, NULL);
    g_assert(dir != NULL);
Comment 1 Tommi Komulainen 2009-10-09 17:15:12 UTC 
Created attachment 145149 [details] [review]
test: handle absolute GJS_TOP_SRCDIR correctly

Seems to be needed for srcdir != builddir
Comment 2 Owen Taylor 2009-10-09 17:28:05 UTC 
Can you explain more about how you are triggering this? Make distcheck (which runs 'make check' for srcdir != builddir) works fine for me. 

(automake-1.11, if that matters)
Comment 3 Tommi Komulainen 2009-10-09 17:41:27 UTC 
mkdir _build
cd _build
$(cd .. && pwd)/configure
make test

or along those lines. The first three steps are jhbuild making. automake 1.10.1
Comment 4 Owen Taylor 2009-10-09 18:22:43 UTC 
(In reply to comment #3)
> mkdir _build
> cd _build
> $(cd .. && pwd)/configure

Ah, that's the issue. If you do the more natural

 ../configure

it works fine. 

The patch looks OK, but could do with a better commit message explaining that its to handle absolute srcdir paths.
Comment 5 Tommi Komulainen 2011-01-10 17:33:29 UTC 
Bug 613234 had better patch.

*** This bug has been marked as a duplicate of bug 613234 ***