After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597899 - DAAP plugin doesn't link to libsoup
DAAP plugin doesn't link to libsoup
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: DAAP
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 598271 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-09 12:14 UTC by Christophe Fergeau
Modified: 2009-10-13 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Link with libsoup (1.00 KB, patch)
2009-10-09 12:14 UTC, Christophe Fergeau 		rejected Details | Review
small cleanup in Makefile.am, not directly related to this bug (1.25 KB, patch)
2009-10-10 12:18 UTC, Christophe Fergeau 		committed Details | Review
link daap plugin with RHYTHMBOX_LIBS (810 bytes, patch)
2009-10-10 12:18 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2009-10-09 12:14:31 UTC 
Created attachment 145125 [details] [review]
Link with libsoup

The DAAP plugin uses symbols from libsoup but doesn't explicitly link to it,
this patch fixes this.
Comment 1 Jonathan Matthew 2009-10-09 23:33:01 UTC 
I thought I'd fixed all of these problems, but I guess not..
Comment 2 Jonathan Matthew 2009-10-09 23:38:53 UTC 
I don't think anything sets SOUP_LIBS and SOUP_CFLAGS any more, so I don't think the patch will help. I guess RHYTHMBOX_LIBS would be the right thing to use. RHYTHMBOX_CFLAGS is already added to INCLUDES, and that has the libsoup cflags in it.
Comment 3 Christophe Fergeau 2009-10-10 08:45:26 UTC 
Hmm, yeah, good point. The thing is, I patched the mandriva package with this patch, and without it the daap plugin couldn't be loaded, and with the patch I could load it. Weird... Fwiw, SOUP_CFLAGS is still used in doc/reference/Makefile.am and tests/Makefile.am.
Comment 4 Christophe Fergeau 2009-10-10 12:15:30 UTC 
Seems it was a side-effect of running autoreconf -fi in addition to applying the patch I attached. Ie the patch didn't fix anything, the autoreconf helped.
Comment 5 Christophe Fergeau 2009-10-10 12:18:12 UTC 
Created attachment 145208 [details] [review]
small cleanup in Makefile.am, not directly related to this bug
Comment 6 Christophe Fergeau 2009-10-10 12:18:42 UTC 
Created attachment 145209 [details] [review]
link daap plugin with RHYTHMBOX_LIBS
Comment 7 Bastien Nocera 2009-10-13 13:30:44 UTC 
*** Bug 598271 has been marked as a duplicate of this bug. ***