Created attachment 145103 [details] [review]
patch

felix, instead of 

+                         gboolean    startup_in_wide_mode,
+                         gboolean    startup_in_fullscreen);

wouldnt it be better to have an enum?

e.g.

0 = normal
1 = wide
2 = fullscreen

and you only pass that int?

otherwise the patch looks straight forward

so what do we do if one wants to start cheese wide and fullscreen?

ah yeah, didnt think of that ;)

you could add a third mode (fs + wide) or you could just make the enum a static array?

don't see a point ;)

what don't you like with the gbooleans?

nothing, i just dont like two function arguments for something where one could be enough

and I don't like enums ;)

could you provide a patch for the patch? :D

Maybe a bitfield flag? Or just pass the whole options struct?
I don't think that code is really getting better looking if not with a major rewrite/gobjectification of cheese window.

Solved in commit 5cef19bf57a58d8ee20c20e33f625aec03befe71