After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597813 - [ssh-agent] Fix support for rsa1 keys
[ssh-agent] Fix support for rsa1 keys
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-10-08 14:26 UTC by Vincent Untz
Modified: 2009-10-09 00:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[ssh-agent] Fix support for rsa1 keys (1.41 KB, patch)
2009-10-08 14:26 UTC, Vincent Untz 		none Details | Review

Description Vincent Untz 2009-10-08 14:26:27 UTC 
The support for constraints created a bug: it's now impossible to make ssh-add work for rsa1 key. That's because we never read the comment for those keys, and so we assume the bytes are contraints, which they are really not.

Attaching a first patch for this.

However, you'll note that we can't save the comment since the CKA_LABEL field is (ab?)used to differentiate rsa1 keys from ssh2 keys.

I don't know how to complete the fix because of this.
Comment 1 Vincent Untz 2009-10-08 14:26:29 UTC 
Created attachment 145054 [details] [review]
[ssh-agent] Fix support for rsa1 keys

Read the comment, instead of ignoring it and using the bytes as if they
were constraints.
Comment 2 Vincent Untz 2009-10-08 14:28:57 UTC 
Downstream bug: https://bugzilla.novell.com/show_bug.cgi?id=540515
Comment 3 Stef Walter 2009-10-09 00:19:45 UTC 
Thanks. Committed. 

Because we're replacing ssh-agent, we want rsa1 one keys added via ssh-add to work, but they aren't exactly first class citizens. Because of that, unless we find a better solution, I think it's fine to abuse the CKA_LABEL field as a way to differentiate them.