GNOME Bugzilla – Bug 597811
[Moblin] Change the toolbar icon to represent device state
Last modified: 2009-10-09 14:17:47 UTC
The design wireframes call for showing a different icon when there is a device connected. Update the MoblinPanel to emit a signal when there is a change in connection type. The path taken is to emit the highest valued BluetoothState of all configured connections. But only when that's different to the last emitted state. Then when the signal is emitted the toolbar icon is set accordingly.
Created attachment 145052 [details] [review] [Moblin] Change the toolbar icon to represent device state
I don't think this makes sense. Showing a state when it's connected doesn't help anyone. If you use a Bluetooth HID device, then it'll always be connected. A good idea would be to show whether the device is connect_ing_.
We should also be showing that.
Showing that it's connected isn't useful. The only devices that do that are phones, and AFAIK, we're not building a UI for a phone here.
No, but we are building a UI for a battery powered portable device so the arguments for showing whether we're connected would be similar as for that on a phone.
Hmm, I have an updated patch for this which shows a different toolbar icon for three states: idle/connected/connecting. For some reason I can't attach it at the minute so will try again tomorrow.
Created attachment 145083 [details] [review] [Moblin] Change the toolbar icon to represent device state The design wireframes call for showing a different icon when there is a device connected and also to display a connecting icon. Update the MoblinPanel to emit a signal when there is a change in connection type. The path taken is to emit the highest valued BluetoothState of all configured connections. But only when that's different to the last emitted state. Then when the signal is emitted the toolbar icon is set accordingly.
Created attachment 145115 [details] [review] [Moblin] Change the toolbar icon to represent device state The design wireframes call for showing a different icon when there is a device connected and also to display a connecting icon. Update the MoblinPanel to emit a signal when there is a change in connection type. The path taken is to emit the highest valued BluetoothState of all configured connections. But only when that's different to the last emitted state. Then when the signal is emitted the toolbar icon is set accordingly.
(In reply to comment #5) > No, but we are building a UI for a battery powered portable device so the > arguments for showing whether we're connected would be similar as for that on a > phone. Except that battery consumption isn't the reason why it's available on phones. The reason why it's shown on phones is because their UIs suck, and when you want to see whether a device is available you'd have to go to Menu -> Settings -> Connectivity -> Bluetooth. In moblin you'd just click on the Bluetooth icon, see that XYZ device is connected, go back to the previous zone. And it's a similar workflow if you want to connect to the device. And your patch means that we wouldn't see whether a device is connecting unless nothing else was connected.
You make a lot of sense, thanks for taking the time to point this out :-) I'll fix up the patch so that it only changes the icon when connecting.
The other point is that what I really wanted to begin with was for the toolip to change, so people didn't even have to click on the panel. Sadly we missed our string freeze for that so it'll be in the next bit.
Showing the number of connected devices is a good idea. Changing the icon depending on whether devices are connected isn't.
Created attachment 145132 [details] [review] [Moblin] Change the toolbar icon when connecting This change adds a member to track whether there is a device connecting. Each time the model changes we iterate to see if there are any devices connecting and set the member variable accordingly. When the boolean connecting variable changes a signal "status-connecting" is emitted with the value of the connecting member.