Can't reproduce here.

The "Mount(2)" is shadowed, so shouldn't appear.

I can reproduce this finally.
On the second plug-in of the device, two icons show up.
Mount(2) infact shows up despite being marked as "is_shadowed".

Must check GVFS now why it still displays...

It's actually up to the front-ends to determine whether or not to show a mount. My guess is that the property value is only changed after the mount is created, causing problems in the front-ends.

Best would probably be to use gvfs-mount's --monitor functionality to see what the volume monitor does.

Ok, checked it with "gvfs-mount -o -i":

---

Volume added:       'Mr’s iPhone'
  Volume(0): Mr’s iPhone
    Type: GProxyVolume (GProxyVolumeMonitorAfc)
    ids:
     uuid: 'ae47*********************************'
    uuid=ae47*********************************
    themed icons:  [phone-apple-iphone]  [phone-apple]  [phone]
    can_mount=1
    can_eject=0
    should_automount=1

Mount added: 'Mr’s iPhone'
  Mount(0): Mr’s iPhone -> afc://ae47*********************************/
    Type: GDaemonMount
    themed icons:  [phone-apple-iphone]  [phone-apple]  [phone]
    can_unmount=1
    can_eject=0
    is_shadowed=0

---

Note "is_shadowed=0". No further event for other afc mounts.

First the volume appears in "nautilus computer:///", a second later the mount appears like noted above.

The same happens in the libgphoto backend, however I noticed that in contrast to the afc backend, the monitor shows "Mount changed" for the gphoto events where "is_shadowed" is toggled to "1".

Now, running "gvfs-mount -li" afterwards, shows the Volume(0), Mount(0) and a Mount(3) which has "is_shadowed=1":

--- 

Volume(1): Mr’s iPhone
  Type: GProxyVolume (GProxyVolumeMonitorAfc)
  ids:
   uuid: 'ae47*********************************'
  uuid=ae47*********************************
  activation_root=afc://ae47*********************************/
  themed icons:  [phone-apple-iphone]  [phone-apple]  [phone]
  can_mount=1
  can_eject=0
  should_automount=1
  Mount(0): Mr’s iPhone -> afc://ae47*********************************2/
    Type: GProxyShadowMount (GProxyVolumeMonitorAfc)
    themed icons:  [phone-apple-iphone]  [phone-apple]  [phone]
    can_unmount=1
    can_eject=0
    is_shadowed=0
Mount(2): iPhone -> gphoto2://[usb:001,015]/
  Type: GDaemonMount
  themed icons:  [camera-photo]  [camera]
  x_content_types: x-content/image-dcf
  can_unmount=1
  can_eject=0
  is_shadowed=1
Mount(3): Mr’s iPhone -> afc://ae47*********************************/
  Type: GDaemonMount
  themed icons:  [phone-apple-iphone]  [phone-apple]  [phone]
  can_unmount=1
  can_eject=0
  is_shadowed=1

---

Nikias found the bug, it was in libusbmuxd.

Unfortunately this is not fixed by the libusbmuxd change (same for Nikias).
I can't reopen the bug though.

Ok, I have done some investigation into this and I think found the issue.

The problem is that the activation_root is not set early enough in the GvfsAfcVolume constructor and thus NULL is returned for the mount.

As the activation_root uri's don't match, it appears two icons are created.

I quickly cooked up something to do it exactly like the gphoto2 backend does and have the activation_root set in the constructor.

Suddenly the icon in the GTK+ dialogs was browsable for me aswell as nautilus correctly listing one icon with alterating mount/unmount context items all the time. Another effect was that the "Choose Application/Perform Action" dialog suddenly showed up again aswell as it should.

Does that sound reasonable?

Created attachment 147747 [details] [review]
Fix shadowed mount showing up next to existing volume icon

The activation_root for a volume was not set when queried and thus
causing two icons created for the same volume/mount.

Now it already sets the activiation_root in the volume constructor
like in the gphoto2 backend.

Please test/give feedback.

+  g_object_set_data_full (G_OBJECT(self), "root", g_object_ref (root), g_object_unref);
This should be:
+  g_object_set_data_full (G_OBJECT(self), "root", root, g_object_unref);

as the newly created "root" GFile should only have one reference when attached to the "self" object (so it's correctly finalized/had its last reference dropped when "self" is unref'ed).

Other than that, looks good to me.

Created attachment 147750 [details] [review]
Fix shadowed mount showing up next to existing volume icon

Thanks for spotting, fixed it.