After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597739 - Test suite not slow-machine-safe(?)
Test suite not slow-machine-safe(?)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.16
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-07 22:12 UTC by Marvin Schmidt
Modified: 2010-03-23 00:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
use tcase_add_loop_test for flvmux' test_index_writing (1.13 KB, patch)
2009-10-14 23:11 UTC, Marvin Schmidt
committed Details | Review

Description Marvin Schmidt 2009-10-07 22:12:59 UTC
On my box

model name	: AMD Athlon(tm) XP 1600+
stepping	: 2
cpu MHz		: 1398.000
cache size	: 256 KB
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 mmx fxsr sse syscall mp mmxext 3dnowext 3dnow
bogomips	: 2796.00
clflush size	: 32
power management: ts

and 512 MB RAM

the elements/flvmux test case always fails with a timeout

after removing the hardcoded CK_DEFAULT_TIMEOUT from the %.torture target in common/check.mak and reconfiguring:

$ CK_DEFAULT_TIMEOUT=3 make elements/flvmux.torture
Running suite(s): flvmux
0%: Checks: 1, Failures: 0, Errors: 1
elements/flvmux.c:46:E:general:test_index_writing:0: (after this point) Test timeout expired
Running suite(s): flvmux
0%: Checks: 1, Failures: 0, Errors: 1
elements/flvmux.c:46:E:general:test_index_writing:0: (after this point) Test timeout expired
Running suite(s): flvmux
0%: Checks: 1, Failures: 0, Errors: 1
elements/flvmux.c:46:E:general:test_index_writing:0: (after this point) Test timeout expired
Running suite(s): flvmux
0%: Checks: 1, Failures: 0, Errors: 1
elements/flvmux.c:46:E:general:test_index_writing:0: (after this point) Test timeout expired
Running suite(s): flvmux
0%: Checks: 1, Failures: 0, Errors: 1
elements/flvmux.c:46:E:general:test_index_writing:0: (after this point) Test timeout expired
Running suite(s): flvmux
0%: Checks: 1, Failures: 0, Errors: 1
elements/flvmux.c:46:E:general:test_index_writing:0: (after this point) Test timeout expired
Running suite(s): flvmux
0%: Checks: 1, Failures: 0, Errors: 1
elements/flvmux.c:46:E:general:test_index_writing:0: (after this point) Test timeout expired
Running suite(s): flvmux
0%: Checks: 1, Failures: 0, Errors: 1
elements/flvmux.c:46:E:general:test_index_writing:0: (after this point) Test timeout expired
Running suite(s): flvmux
0%: Checks: 1, Failures: 0, Errors: 1
elements/flvmux.c:46:E:general:test_index_writing:0: (after this point) Test timeout expired
Running suite(s): flvmux
0%: Checks: 1, Failures: 0, Errors: 1
elements/flvmux.c:46:E:general:test_index_writing:0: (after this point) Test timeout expired
make: *** [elements/flvmux.torture] Error 1

Only with CK_DEFAULT_TIMEOUT > 5 it passes the test every time.

elements/videocrop times out occassionally


On my laptop

model name	: Intel(R) Pentium(R) M processor 1.60GHz
stepping	: 6
cpu MHz		: 1594.821
cache size	: 2048 KB
flags		: fpu vme de pse tsc msr mce cx8 sep mtrr pge mca cmov clflush dts acpi mmx fxsr sse sse2 ss tm pbe bts est tm2
bogomips	: 3189.64

I'm not having this issue
Comment 1 Sebastian Dröge (slomo) 2009-10-08 11:23:48 UTC
Yes, many tests are not "slow-machine-safe". Not much we can do about that without using a higher timeout (which could still be too low elsewhere, the timeouts already have values that are working most of the time) or without reducing the usefulness of the tests.
Comment 2 Tim-Philipp Müller 2009-10-08 11:43:22 UTC
Actually, there might be something we can do for looping tests, see http://sourceforge.net/tracker/?func=detail&aid=1549835&group_id=28255&atid=392816 (haven't looked at it yet in detail though).
Comment 3 Marvin Schmidt 2009-10-14 23:11:46 UTC
Created attachment 145459 [details] [review]
use tcase_add_loop_test for flvmux' test_index_writing
Comment 4 Marvin Schmidt 2009-10-14 23:13:43 UTC
Thanks for the hint, Tim
With the above patch I can pass the test.
I'm not sure how to fix the videocrop test, though
Comment 5 Sebastian Dröge (slomo) 2009-10-15 04:02:22 UTC
commit 632a6d7e374fba89a88de9eb3e6fef86fea72014
Author: Marvin Schmidt <marv@exherbo.org>
Date:   Wed Oct 14 18:58:06 2009 +0200

    flvmux: Use loop test to prevent timeout on slow machines
    
    Partially fixes bug #597739.
Comment 6 Sebastian Dröge (slomo) 2009-10-15 04:05:54 UTC
(In reply to comment #4)
> Thanks for the hint, Tim
> With the above patch I can pass the test.
> I'm not sure how to fix the videocrop test, though

You could get the length of this list over which it iterates before calling tcase_add_test() and use that number as the loop parameter. And then in the tests jump to the i-th element of the list and only do the test for this.
Comment 7 Tim-Philipp Müller 2010-03-23 00:21:37 UTC
commit c4a9ed774eb7147f3a42dfaa6edab8fce874b6a1
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue Mar 23 00:15:15 2010 +0000

    tests: use loop test for long-running videocrop check
    
    This should avoid timeouts on slow machines.
    
    Fixes #597739.